On Fri, Sep 20, 2019 at 10:02:28AM -0700, Florian Fainelli wrote: > On 9/20/19 10:00 AM, Thierry Reding wrote: > > From: Thierry Reding > > > > The DWMAC 4.10 supports the same enhanced addressing mode as later > > generations. Parse this capability from the hardware feature registers > > and set the EAME (Enhanced Addressing Mode Enable) bit when necessary. > > Do you think these two patches should have companion Fixes: tag? They > are definitively bug fixes, but maybe you would also want those to be > back ported to -stable trees? I wouldn't really consider these bug fixes. They're more along the lines of feature additions. The driver previously didn't support EAME and that was fine. The fact that it never worked under specific circumstances is not a bug or regression, really. Thierry > > Thierry Reding (2): > > net: stmmac: Only enable enhanced addressing mode when needed > > net: stmmac: Support enhanced addressing mode for DWMAC 4.10 > > > > drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1 + > > .../ethernet/stmicro/stmmac/dwmac4_descs.c | 4 ++-- > > .../net/ethernet/stmicro/stmmac/dwmac4_dma.c | 22 +++++++++++++++++++ > > .../net/ethernet/stmicro/stmmac/dwmac4_dma.h | 3 +++ > > .../ethernet/stmicro/stmmac/dwxgmac2_dma.c | 5 ++++- > > .../net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++++ > > include/linux/stmmac.h | 1 + > > 7 files changed, 39 insertions(+), 3 deletions(-) > > > > > -- > Florian