From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37904C4360D for ; Sun, 22 Sep 2019 01:55:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A36B208C0 for ; Sun, 22 Sep 2019 01:55:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="K1naXdvo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbfIVByr (ORCPT ); Sat, 21 Sep 2019 21:54:47 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:37240 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727076AbfIVByr (ORCPT ); Sat, 21 Sep 2019 21:54:47 -0400 Received: by mail-pl1-f194.google.com with SMTP id u20so674676plq.4 for ; Sat, 21 Sep 2019 18:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=rYCMTzf5XfwKOsEzh41FsTMKmDMxiUBIaULFJietvkw=; b=K1naXdvogaEe5TxFqSMSp7rDFEAdpuCR6rMwFHF6+4xLaFXeYhBbRiO6hk5gh3YqpU jwwB0ltth8D95PruCSjAOPsUo2eoTxBTaercBm/obwPCKjWSD2kA0vOA/uMTFROdRV/F VPI/omVqHyoG24hazhflJa03GRTeRHxfTeka+u2+Wo2d+iu88ol6oTI27m0bHtGiv/J5 oqz8TurWzaQJkX7Z6xKq1VryuuitQQqc2DBqyRA9qh/BMMy5/9fF8tJbRbV0O4T1dA02 r5P6UMjdsvoJvR0FoZVOb1yXgikZsx3cwdIISP9CjO6Ya+mV0oL9HYnGDubUBjTmRVjU EkeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=rYCMTzf5XfwKOsEzh41FsTMKmDMxiUBIaULFJietvkw=; b=npSJ2C8AGj5ItMzsAu6SQPLLD9HwSCOatYHRyoDmTx691H/vEOg92PWI3Cpg9tbDrw hJe8RD28q6gP514W1hy72bXuzfBDRyQqyZvQwYRkodl9+5LEARLpAcFGn/x9LwPisbYl nSSOVAIUoxmv9/BnfEaslgs8n+/6PFti3C4EE/4rWQnlCgdF+ZJBcr8ExyLgTSaG7UX7 19OzBiutdddLuGPzcR1BfLfBOCFr3qTRmQL8oGDYQ6srDX8OBMB/jNKReTdc1OY73Yc+ wPXbexhuXRuolMfvEcqY0B6Flv7Lpi9nuF0nPWzOgE3ig2g9IaZhYTESxa2oP0o7Srnu 9SLA== X-Gm-Message-State: APjAAAW4hR3gnsJr7r1H/OM8GuZ+K1ECH9vLVRSZc0AH8pPYU4FZNoUz 2wtBqKpzamXXu/zXnZziOIDC+A== X-Google-Smtp-Source: APXvYqxYgsXnRkO1NtPedKypWdAMA42UdD6RehIiW7hqLUVf5E2h9si/0m974x4xEY25hFo7Ku9ezA== X-Received: by 2002:a17:902:9a43:: with SMTP id x3mr25633936plv.145.1569117284881; Sat, 21 Sep 2019 18:54:44 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id f6sm8097858pfq.169.2019.09.21.18.54.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Sep 2019 18:54:44 -0700 (PDT) Date: Sat, 21 Sep 2019 18:54:41 -0700 From: Jakub Kicinski To: Bjorn Andersson Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla , stable@vger.kernel.org Subject: Re: [PATCH] net: qrtr: Stop rx_worker before freeing node Message-ID: <20190921185441.0350ce9e@cakuba.netronome.com> In-Reply-To: <20190918172117.4116-1-bjorn.andersson@linaro.org> References: <20190918172117.4116-1-bjorn.andersson@linaro.org> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 18 Sep 2019 10:21:17 -0700, Bjorn Andersson wrote: > As the endpoint is unregistered there might still be work pending to > handle incoming messages, which will result in a use after free > scenario. The plan is to remove the rx_worker, but until then (and for > stable@) ensure that the work is stopped before the node is freed. > > Fixes: bdabad3e363d ("net: Add Qualcomm IPC router") > Cc: stable@vger.kernel.org > Signed-off-by: Bjorn Andersson Thanks! Applied, and queued for 4.9+. FWIW Dave handles the stable submission himself, so no need to CC stable on networking patches: https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-i-see-a-network-patch-and-i-think-it-should-be-backported-to-stable