From: Carlos Antonio Neira Bustos <cneirabustos@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, yhs@fb.com, ebiederm@xmission.com,
brouer@redhat.com, bpf@vger.kernel.org
Subject: Re: [PATCH V11 0/4] BPF: New helper to obtain namespace data from current task
Date: Tue, 24 Sep 2019 15:14:32 -0300 [thread overview]
Message-ID: <20190924181432.GA9944@frodo.byteswizards.com> (raw)
In-Reply-To: <20190924180117.GA5889@pc-63.home>
On Tue, Sep 24, 2019 at 08:01:17PM +0200, Daniel Borkmann wrote:
> On Tue, Sep 24, 2019 at 12:20:01PM -0300, Carlos Neira wrote:
> > Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's
> > scripts but this helper returns the pid as seen by the root namespace which is
> > fine when a bcc script is not executed inside a container.
> > When the process of interest is inside a container, pid filtering will not work
> > if bpf_get_current_pid_tgid() is used.
> > This helper addresses this limitation returning the pid as it's seen by the current
> > namespace where the script is executing.
> >
> > In the future different pid_ns files may belong to different devices, according to the
> > discussion between Eric Biederman and Yonghong in 2017 Linux plumbers conference.
> > To address that situation the helper requires inum and dev_t from /proc/self/ns/pid.
> > This helper has the same use cases as bpf_get_current_pid_tgid() as it can be
> > used to do pid filtering even inside a container.
> >
> > Signed-off-by: Carlos Neira <cneirabustos@gmail.com>
> >
> > Carlos Neira (4):
> > fs/nsfs.c: added ns_match
> > bpf: added new helper bpf_get_ns_current_pid_tgid
> > tools: Added bpf_get_ns_current_pid_tgid helper
> > tools/testing/selftests/bpf: Add self-tests for new helper. self tests
> > added for new helper
>
> bpf-next is currently closed due to merge window. Please resubmit once back open, thanks.
Thanks, Daniel, I'll do so.
Bests.
next prev parent reply other threads:[~2019-09-24 18:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 15:20 [PATCH V11 0/4] BPF: New helper to obtain namespace data from current task Carlos Neira
2019-09-24 15:20 ` [PATCH bpf-next v11 1/4] fs/nsfs.c: added ns_match Carlos Neira
2019-09-24 15:20 ` [PATCH bpf-next v11 2/4] bpf: added new helper bpf_get_ns_current_pid_tgid Carlos Neira
2019-09-27 16:15 ` Andrii Nakryiko
2019-09-27 16:59 ` Yonghong Song
2019-09-27 17:24 ` Andrii Nakryiko
2019-09-28 1:42 ` Carlos Antonio Neira Bustos
2019-09-24 15:20 ` [PATCH bpf-next v11 3/4] tools: Added bpf_get_ns_current_pid_tgid helper Carlos Neira
2019-09-25 3:27 ` Yonghong Song
2019-09-24 15:20 ` [PATCH bpf-next v11 4/4] tools/testing/selftests/bpf: Add self-tests for new helper Carlos Neira
2019-09-25 16:07 ` Yonghong Song
2019-09-25 20:33 ` Carlos Antonio Neira Bustos
2019-09-24 18:01 ` [PATCH V11 0/4] BPF: New helper to obtain namespace data from current task Daniel Borkmann
2019-09-24 18:14 ` Carlos Antonio Neira Bustos [this message]
2019-09-26 0:59 ` Eric W. Biederman
2019-09-26 15:51 ` Yonghong Song
2019-09-26 16:16 ` John Fastabend
2019-09-26 17:01 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924181432.GA9944@frodo.byteswizards.com \
--to=cneirabustos@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).