From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D14C432C2 for ; Wed, 25 Sep 2019 11:45:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E63FC2054F for ; Wed, 25 Sep 2019 11:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391222AbfIYLp5 (ORCPT ); Wed, 25 Sep 2019 07:45:57 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:34744 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728540AbfIYLp5 (ORCPT ); Wed, 25 Sep 2019 07:45:57 -0400 Received: from localhost (unknown [65.39.69.237]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AE09E14649696; Wed, 25 Sep 2019 04:45:55 -0700 (PDT) Date: Wed, 25 Sep 2019 13:45:54 +0200 (CEST) Message-Id: <20190925.134554.2101760650151955552.davem@davemloft.net> To: jeliantsurux@gmail.com Cc: gnault@redhat.com, paulus@samba.org, netdev@vger.kernel.org Subject: Re: [PATCH net] ppp: Fix memory leak in ppp_write From: David Miller In-Reply-To: <20190922074531.GA1450@DESKTOP> References: <20190922074531.GA1450@DESKTOP> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Sep 2019 04:45:56 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Takeshi Misawa Date: Sun, 22 Sep 2019 16:45:31 +0900 > When ppp is closing, __ppp_xmit_process() failed to enqueue skb > and skb allocated in ppp_write() is leaked. > > syzbot reported : ... > Fix this by freeing skb, if ppp is closing. > > Fixes: 6d066734e9f0 ("ppp: avoid loop in xmit recursion detection code") > Reported-and-tested-by: syzbot+d9c8bf24e56416d7ce2c@syzkaller.appspotmail.com > Signed-off-by: Takeshi Misawa Applied and queued up for -stable.