From: David Miller <davem@davemloft.net>
To: pmalani@chromium.org
Cc: hayeswang@realtek.com, grundler@chromium.org,
netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH] r8152: Use guard clause and fix comment typos
Date: Thu, 26 Sep 2019 09:00:32 +0200 (CEST) [thread overview]
Message-ID: <20190926.090032.1228409542844231601.davem@davemloft.net> (raw)
In-Reply-To: <20190923222657.253628-1-pmalani@chromium.org>
From: Prashant Malani <pmalani@chromium.org>
Date: Mon, 23 Sep 2019 15:26:57 -0700
> Use a guard clause in tx_bottom() to reduce the indentation of the
> do-while loop. In doing so, convert the do-while to a while to make the
> guard clause checks consistent.
>
> Also, fix a couple of spelling and grammatical mistakes in the
> r8152_csum_workaround() function comment.
>
> Change-Id: I460befde150ad92248fd85b0f189ec2df2ab8431
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> Reviewed-by: Grant Grundler <grundler@chromium.org>
This is only approiate for net-next, so please resubmit this when the
net-next tree opens back up.
prev parent reply other threads:[~2019-09-26 7:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 22:26 [PATCH] r8152: Use guard clause and fix comment typos Prashant Malani
2019-09-24 2:47 ` Hayes Wang
2019-09-24 23:47 ` Grant Grundler
2019-09-25 0:28 ` Grant Grundler
2019-09-26 7:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926.090032.1228409542844231601.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=grundler@chromium.org \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).