From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE08CC4360C for ; Thu, 26 Sep 2019 12:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B39E72053B for ; Thu, 26 Sep 2019 12:09:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="kFx6jlD/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbfIZMJ1 (ORCPT ); Thu, 26 Sep 2019 08:09:27 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38892 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbfIZMJ1 (ORCPT ); Thu, 26 Sep 2019 08:09:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FR/mHngE5HbT/uqxBpiJEJEzHfI2HKsFHQ7kEhbaacM=; b=kFx6jlD/Le6t10WNuUy2btsrhO QSt14kXkqJJxuw54aksMcTrXiv3EZpC1gRnB1/T8WWVnpw5Ud8FTh+ZPtfF70xZleMDh5GMqE9d7G ZVbi2lEbMUKc7J0hR7N390WRn2tgKiwLe8JTV58okEU9X+48gzZ/rV3YExFCLl9xoZto=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1iDSaI-0001oU-SL; Thu, 26 Sep 2019 14:09:22 +0200 Date: Thu, 26 Sep 2019 14:09:22 +0200 From: Andrew Lunn To: Hans Andersson Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, antoine.tenart@bootlin.com, Hans Andersson Subject: Re: [PATCH] net: phy: micrel: add Asym Pause workaround for KSZ9021 Message-ID: <20190926120922.GD1864@lunn.ch> References: <20190926075437.18088-1-haan@cellavision.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190926075437.18088-1-haan@cellavision.se> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Sep 26, 2019 at 09:54:37AM +0200, Hans Andersson wrote: > From: Hans Andersson > > The Micrel KSZ9031 PHY may fail to establish a link when the Asymmetric > Pause capability is set. This issue is described in a Silicon Errata > (DS80000691D or DS80000692D), which advises to always disable the > capability. > > Micrel KSZ9021 has no errata, but has the same issue with Asymmetric Pause. > This patch apply the same workaround as the one for KSZ9031. > > Signed-off-by: Hans Andersson Fixes: 3aed3e2a143c ("net: phy: micrel: add Asym Pause workaround") This is not the best fixes: tag, since it was not that change which broke it. But going further back will be hard. Reviewed-by: Andrew Lunn Andrew