From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andriin@fb.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
andrii.nakryiko@gmail.com, kernel-team@fb.com
Subject: Re: [PATCH bpf] libbpf: teach btf_dumper to emit stand-alone anonymous enum definitions
Date: Thu, 26 Sep 2019 14:43:28 +0200 [thread overview]
Message-ID: <20190926124328.GA6563@pc-63.home> (raw)
In-Reply-To: <20190925203745.3173184-1-andriin@fb.com>
On Wed, Sep 25, 2019 at 01:37:45PM -0700, Andrii Nakryiko wrote:
> BTF-to-C converter previously skipped anonymous enums in an assumption
> that those are embedded in struct's field definitions. This is not
> always the case and a lot of kernel constants are defined as part of
> anonymous enums. This change fixes the logic by eagerly marking all
> types as either referenced by any other type or not. This is enough to
> distinguish two classes of anonymous enums and emit previously omitted
> enum definitions.
>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Applied, thanks!
prev parent reply other threads:[~2019-09-26 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 20:37 [PATCH bpf] libbpf: teach btf_dumper to emit stand-alone anonymous enum definitions Andrii Nakryiko
2019-09-26 12:43 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926124328.GA6563@pc-63.home \
--to=daniel@iogearbox.net \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).