netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
	netdev@vger.kernel.org, steffen.klassert@secunet.com,
	paulb@mellanox.com, vladbu@mellanox.com
Subject: Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing
Date: Thu, 26 Sep 2019 21:09:20 +0200	[thread overview]
Message-ID: <20190926190920.GC9938@breakpoint.cc> (raw)
In-Reply-To: <1ad4b9f0-c9d4-954b-eafe-8652ea6ce409@gmail.com>

Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > -	secpath_reset(skb);
> > +	skb_ext_reset(skb);
> >  	nf_reset(skb);
> >  	nf_reset_trace(skb);
> 
> 
> It is unfortunate nf_reset(skb) will call skb_ext_del(skb, SKB_EXT_BRIDGE_NF),
> which is useless after skb_ext_reset(skb) 
> 
> Maybe time for a nf_ct_reset() helper only dealing with nfct.

Agree, but that seems more like -next material?

  reply	other threads:[~2019-09-26 19:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26 18:37 [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing Florian Westphal
2019-09-26 19:05 ` Eric Dumazet
2019-09-26 19:09   ` Florian Westphal [this message]
2019-09-26 19:16     ` Eric Dumazet
2019-09-27 18:40 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190926190920.GC9938@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulb@mellanox.com \
    --cc=steffen.klassert@secunet.com \
    --cc=vladbu@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).