From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net 0/3] tcp: provide correct skb->priority
Date: Fri, 27 Sep 2019 12:05:33 +0200 (CEST) [thread overview]
Message-ID: <20190927.120533.464156831739223782.davem@davemloft.net> (raw)
In-Reply-To: <20190924150116.199028-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Tue, 24 Sep 2019 08:01:13 -0700
> SO_PRIORITY socket option requests TCP egress packets
> to contain a user provided value.
>
> TCP manages to send most packets with the requested values,
> notably for TCP_ESTABLISHED state, but fails to do so for
> few packets.
>
> These packets are control packets sent on behalf
> of SYN_RECV or TIME_WAIT states.
>
> Note that to test this with packetdrill, it is a bit
> of a hassle, since packetdrill can not verify priority
> of egress packets, other than indirect observations,
> using for example sch_prio on its tunnel device.
>
> The bad skb priorities cause problems for GCP,
> as this field is one of the keys used in routing.
Series applied, thanks Eric.
prev parent reply other threads:[~2019-09-27 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 15:01 [PATCH net 0/3] tcp: provide correct skb->priority Eric Dumazet
2019-09-24 15:01 ` [PATCH net 1/3] ipv6: add priority parameter to ip6_xmit() Eric Dumazet
2019-09-24 15:01 ` [PATCH net 2/3] ipv6: tcp: provide sk->sk_priority to ctl packets Eric Dumazet
2019-09-24 15:01 ` [PATCH net 3/3] tcp: honor SO_PRIORITY in TIME_WAIT state Eric Dumazet
2019-09-27 10:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927.120533.464156831739223782.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).