From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E72C388F4 for ; Fri, 27 Sep 2019 18:24:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52A8B217D7 for ; Fri, 27 Sep 2019 18:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569608652; bh=4swEvpXaqSRC7XJbFySxlHY6O59YmXPHl6S6u/bn7gk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nPkv7dOgBghi8gIyhk3VLkUSQJjBI/Dj2wqB8zcYjLAXRpMHnj/00SsAr4cinwT0I CEOS4nXe9K1lc82MvE3VHQ+arUEvnqCuiJFZMox6oLv0pSzkUMiJ0mWtyAJY8TpecY 36zsaGPtXzObFTFIqGL3cnoR7u9RT6Eu5MngxwP0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728143AbfI0SYL (ORCPT ); Fri, 27 Sep 2019 14:24:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:33398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbfI0SYL (ORCPT ); Fri, 27 Sep 2019 14:24:11 -0400 Received: from localhost (unknown [62.119.166.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41F3D21655; Fri, 27 Sep 2019 18:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569608649; bh=4swEvpXaqSRC7XJbFySxlHY6O59YmXPHl6S6u/bn7gk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=02bLKIX+cGcqGYknMvQpYeQxL9frtu2emAO8Rp40APIVL6QS7TMORC0NaPoY08ENO tlxYFIV9KIzkTq18RBxYR+Tm/oOmLLFgVf7sYYiS0uiCVnEGf3DCt35MfgnCoO921k 85E9OA8WHg2t6CzQnpSTEtY6XJJx7P98VTn3tm1Q= Date: Fri, 27 Sep 2019 20:23:46 +0200 From: "gregkh@linuxfoundation.org" To: "Saleem, Shiraz" Cc: Leon Romanovsky , "Kirsher, Jeffrey T" , "dledford@redhat.com" , "jgg@mellanox.com" , "Ismail, Mustafa" , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions Message-ID: <20190927182346.GE1804168@kroah.com> References: <20190926164519.10471-1-jeffrey.t.kirsher@intel.com> <20190926164519.10471-16-jeffrey.t.kirsher@intel.com> <20190926174948.GE14368@unreal> <9DD61F30A802C4429A01CA4200E302A7AC702BC6@fmsmsx123.amr.corp.intel.com> <20190927044653.GF14368@unreal> <9DD61F30A802C4429A01CA4200E302A7AC704647@fmsmsx123.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9DD61F30A802C4429A01CA4200E302A7AC704647@fmsmsx123.amr.corp.intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 27, 2019 at 02:28:20PM +0000, Saleem, Shiraz wrote: > > Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions > > > > On Thu, Sep 26, 2019 at 07:49:33PM +0000, Saleem, Shiraz wrote: > > > > Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility > > > > definitions > > > > > > > > On Thu, Sep 26, 2019 at 09:45:14AM -0700, Jeff Kirsher wrote: > > > > > From: Mustafa Ismail > > > > > > > > > > Add miscellaneous utility functions and headers. > > > > > > > > > > Signed-off-by: Mustafa Ismail > > > > > Signed-off-by: Shiraz Saleem > > > > > --- > > > > > drivers/infiniband/hw/irdma/osdep.h | 108 ++ > > > > > drivers/infiniband/hw/irdma/protos.h | 96 ++ > > > > > drivers/infiniband/hw/irdma/status.h | 70 + > > > > > drivers/infiniband/hw/irdma/utils.c | 2333 > > > > > ++++++++++++++++++++++++++ > > > > > 4 files changed, 2607 insertions(+) create mode 100644 > > > > > drivers/infiniband/hw/irdma/osdep.h > > > > > create mode 100644 drivers/infiniband/hw/irdma/protos.h > > > > > create mode 100644 drivers/infiniband/hw/irdma/status.h > > > > > create mode 100644 drivers/infiniband/hw/irdma/utils.c > > > > > > > > > > diff --git a/drivers/infiniband/hw/irdma/osdep.h > > > > > b/drivers/infiniband/hw/irdma/osdep.h > > > > > new file mode 100644 > > > > > index 000000000000..5885b6fa413d > > > > > --- /dev/null > > > > > +++ b/drivers/infiniband/hw/irdma/osdep.h > > > > > @@ -0,0 +1,108 @@ > > > > > +/* SPDX-License-Identifier: GPL-2.0 or Linux-OpenIB */ > > > > > +/* Copyright (c) 2019, Intel Corporation. */ > > > > > + > > > > > +#ifndef IRDMA_OSDEP_H > > > > > +#define IRDMA_OSDEP_H > > > > > + > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +/* get readq/writeq support for 32 bit kernels, use the low-first > > > > > +version */ #include > > > > > + > > > > > +#define MAKEMASK(m, s) ((m) << (s)) > > > > > > > > It is a little bit over-macro. > > > > > > > > > > Why is this a problem? > > > We are not translating any basic kernel construct here. > > > > See BIT() definition. > > > OK. And? And you just re-created GENMASK(). Please use in-kernel definitions instead of creating your own. thanks, greg k-h