From: Andrew Lunn <andrew@lunn.ch>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com,
pabeni@redhat.com, edumazet@google.com, petrm@mellanox.com,
sd@queasysnail.net, f.fainelli@gmail.com,
stephen@networkplumber.org, mlxsw@mellanox.com
Subject: Re: [patch net-next 2/3] net: introduce per-netns netdevice notifiers
Date: Mon, 30 Sep 2019 15:38:24 +0200 [thread overview]
Message-ID: <20190930133824.GA14745@lunn.ch> (raw)
In-Reply-To: <20190930081511.26915-3-jiri@resnulli.us>
> static int call_netdevice_notifiers_info(unsigned long val,
> struct netdev_notifier_info *info)
> {
> + struct net *net = dev_net(info->dev);
> + int ret;
> +
> ASSERT_RTNL();
> +
> + /* Run per-netns notifier block chain first, then run the global one.
> + * Hopefully, one day, the global one is going to be removed after
> + * all notifier block registrators get converted to be per-netns.
> + */
Hi Jiri
Is that really going to happen? register_netdevice_notifier() is used
in 130 files. Do you plan to spend the time to make it happen?
> + ret = raw_notifier_call_chain(&net->netdev_chain, val, info);
> + if (ret & NOTIFY_STOP_MASK)
> + return ret;
> return raw_notifier_call_chain(&netdev_chain, val, info);
> }
Humm. I wonder about NOTIFY_STOP_MASK here. These are two separate
chains. Should one chain be able to stop the other chain? Are there
other examples where NOTIFY_STOP_MASK crosses a chain boundary?
Andrew
next prev parent reply other threads:[~2019-09-30 13:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 8:15 [patch net-next 0/3] net: introduce per-netns netdevice notifiers and use them in mlxsw Jiri Pirko
2019-09-30 8:15 ` [patch net-next 1/3] net: push loops and nb calls into helper functions Jiri Pirko
2019-09-30 8:15 ` [patch net-next 2/3] net: introduce per-netns netdevice notifiers Jiri Pirko
2019-09-30 13:38 ` Andrew Lunn [this message]
2019-09-30 14:23 ` Jiri Pirko
2019-09-30 15:33 ` Andrew Lunn
2019-09-30 18:01 ` Jiri Pirko
2019-10-02 15:47 ` David Miller
2019-09-30 8:15 ` [patch net-next 3/3] mlxsw: spectrum: Use per-netns netdevice notifier registration Jiri Pirko
2019-10-02 15:52 ` [patch net-next 0/3] net: introduce per-netns netdevice notifiers and use them in mlxsw David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930133824.GA14745@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@mellanox.com \
--cc=sd@queasysnail.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).