From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C2DDC32792 for ; Mon, 30 Sep 2019 14:09:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1ED0E216F4 for ; Mon, 30 Sep 2019 14:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569852555; bh=R8eiJJTzcyo1yGN0aQ9ZsBckQuDguFk2uTpXskUiW1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HwAQU05KD8QAZQ0NvIxBaqmbFOpPBOAYOKJQQ340gdugqCCceagQdqGx1S7wq2m9q xz5O0M9Ah+Fu0F9uLi7Pwxsk0+8iKOyis7TWOkDng0Nw5ox3TxDtDpO31ydGTj5npx HthyB/TGgXld3/cqvIrda9cpCgKwyFekLtQYewe0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731706AbfI3OJH (ORCPT ); Mon, 30 Sep 2019 10:09:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:45248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730902AbfI3OJG (ORCPT ); Mon, 30 Sep 2019 10:09:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B9C621855; Mon, 30 Sep 2019 14:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569852544; bh=R8eiJJTzcyo1yGN0aQ9ZsBckQuDguFk2uTpXskUiW1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aIs88nSuxyAskoZMsBGB2UXyVECbgNLhEJKqQDenYOunFdkOmk+WtYp9X58uyeqoD Y9QU7ZMNCHiSBN8gaQ4NNqwoP31pKCe59/6nsv72OaXMHqryOaf/lpRGqMdyifCtLP MEmimYrwR90Ec6oSbuaA6apvwkvtEwJ0k/KFhj1Y= Date: Mon, 30 Sep 2019 16:06:21 +0200 From: Greg KH To: Sven Van Asbroeck Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , Linus Walleij , Enrico Weigelt , Oliver Hartkopp , jan.kiszka@siemens.com, Frank Iwanitz , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 3/5] staging: fieldbus core: add support for device configuration Message-ID: <20190930140621.GB2280096@kroah.com> References: <20190918183552.28959-1-TheSven73@gmail.com> <20190918183552.28959-4-TheSven73@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190918183552.28959-4-TheSven73@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 18, 2019 at 02:35:50PM -0400, Sven Van Asbroeck wrote: > Support device configuration by adding > > - an in-kernel driver config API, and > - a configfs-based userspace config ABI > > In short, drivers pick a subset from a set of standardized config > properties. This is exposed by the fieldbus core as configfs files. > Userspace may then configure the device by writing to these configfs > files, prior to enabling the device. Why is a new way of doing configuration needed here? What does this provide that the current code doesn't already do? And have you looked at the recent configfs fixes to make sure this code still works with them? I can't test this so rebasing this on 5.4-rc1 would be good for you to do first. thanks, greg k-h