From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02ABFC32792 for ; Mon, 30 Sep 2019 23:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6EE220815 for ; Mon, 30 Sep 2019 23:36:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="AmQ+AiEE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731968AbfI3XgP (ORCPT ); Mon, 30 Sep 2019 19:36:15 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:36946 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727497AbfI3XgO (ORCPT ); Mon, 30 Sep 2019 19:36:14 -0400 Received: by mail-qk1-f193.google.com with SMTP id u184so9488911qkd.4 for ; Mon, 30 Sep 2019 16:36:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=sX8lP/NxKY5NY6OP8Hy/bpDIGodskPAFHGazmkozDMc=; b=AmQ+AiEEh204AU33XWczaSvDTBysZ89p78+tc2D+ddHjjrGgPAzq2dwOGX4abk8kaJ kYnfQbKQihfw9pc+IPHJujf/Vdh9+DGnSJf7O1SWDXgUe04D4iGe+UdJi6UqVLqgCH2f WXb7EFrRtiVTIfM3mQAmgDiLj7Qe5GG6Mq8hg6tp+PCknW2mLkn+pObCs7lZxHzBj/+3 Ouwp4GTAbolANGXkB08KtpUkyZnb3q/bqf//5reFMrFnpY1aJe9BsVgusnZN44bxWn+Z mdkR05ZwphCtQX7p3CKvJtUvYC16ALmT8WOkyr11H/w1tKY8CeU6QO05CEE/kFsK2tHi 1VSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=sX8lP/NxKY5NY6OP8Hy/bpDIGodskPAFHGazmkozDMc=; b=DbbTgP80fjROajYIZIEd7DdWgw4nSDQD8o/6VXp6XdZA1pIvDvTamCu92xr5SpOnLm cKnd4JRDcUdsqYSUQjsxDkWVSQYQ3OF3dvAfg6neK4SCd9rvFalUi+qtrHOjySEUmA7v bRNRXLzEw48GcjQckOz49sSMyA1IcS6/CRT28a6RYSF1oO/IWtD/fqvhdTo2t/aDg6f5 BFD0NKLROVcu8lasd6qN5SjhUO8DjPTPBE53sByqxAFvdszACERZChRZF7atk4qnQ7Ko bWY58/QZY8GH7qbV691RUqaUPcK7GHejwWPEfFIlaNPgpZk2U1fyny83+6bEKwX6//z8 2/Kg== X-Gm-Message-State: APjAAAXOgQARMwQHtm+ptD9vTVKUi9NswLE9D4bSkyBrkZvyxAdQnq6H 7wl7jHHzIs1RM3IJb+wX5YVNoA== X-Google-Smtp-Source: APXvYqzUbm9zOjImXcz+Z4ky8ISE4hSsZz7ojHltyxLuYM8iiH8VJlG6OTG/V/7NEgRa4ptVdOZkBQ== X-Received: by 2002:a37:7ac1:: with SMTP id v184mr3029047qkc.129.1569886573901; Mon, 30 Sep 2019 16:36:13 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id z200sm7163130qkb.5.2019.09.30.16.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 16:36:13 -0700 (PDT) Date: Mon, 30 Sep 2019 16:36:09 -0700 From: Jakub Kicinski To: Song Liu Cc: Andrii Nakryiko , Song Liu , Andrii Nakryiko , bpf , Networking , "Alexei Starovoitov" , Daniel Borkmann , Kernel Team Subject: Re: [PATCH bpf-next 2/6] libbpf: move bpf_helpers.h, bpf_endian.h into libbpf Message-ID: <20190930163609.52187526@cakuba.netronome.com> In-Reply-To: References: <20190930185855.4115372-1-andriin@fb.com> <20190930185855.4115372-3-andriin@fb.com> <20190930161814.381c9bb0@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 30 Sep 2019 23:25:33 +0000, Song Liu wrote: > > On Sep 30, 2019, at 4:18 PM, Jakub Kicinski wrote: > > > > On Mon, 30 Sep 2019 15:58:35 -0700, Andrii Nakryiko wrote: > >> On Mon, Sep 30, 2019 at 3:55 PM Song Liu wrote: > >>> > >>> On Mon, Sep 30, 2019 at 1:43 PM Andrii Nakryiko wrote: > >>>> > >>>> Make bpf_helpers.h and bpf_endian.h official part of libbpf. Ensure they > >>>> are installed along the other libbpf headers. > >>>> > >>>> Signed-off-by: Andrii Nakryiko > >>> > >>> Can we merge/rearrange 2/6 and 3/6, so they is a git-rename instead of > >>> many +++ and ---? > >> > >> I arranged them that way because of Github sync. We don't sync > >> selftests/bpf changes to Github, and it causes more churn if commits > >> have a mix of libbpf and selftests changes. > >> > >> I didn't modify bpf_helpers.h/bpf_endian.h between those patches, so > >> don't worry about reviewing contents ;) > > > > I thought we were over this :/ Please merge the patches. > > Andrii changed syntax for BPF_CORE_READ(). I guess that is new? I meant the battle to not split changes into harder to review, and less logical form based on what some random, never review upstream script can or cannot do :) I was responding to the "don't worry about reviewing contents" - as you pointed out git would just generate a move..