From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 070EEC352AA for ; Tue, 1 Oct 2019 16:03:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D66B72053B for ; Tue, 1 Oct 2019 16:03:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733073AbfJAQDY (ORCPT ); Tue, 1 Oct 2019 12:03:24 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49020 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbfJAQDY (ORCPT ); Tue, 1 Oct 2019 12:03:24 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A1C82154A804B; Tue, 1 Oct 2019 09:03:23 -0700 (PDT) Date: Tue, 01 Oct 2019 09:03:20 -0700 (PDT) Message-Id: <20191001.090320.1192378852987776883.davem@davemloft.net> To: o.rempel@pengutronix.de Cc: jcliburn@gmail.com, chris.snook@gmail.com, andrew@lunn.ch, kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: ag71xx: fix mdio subnode support From: David Miller In-Reply-To: <20191001064147.23633-1-o.rempel@pengutronix.de> References: <20191001064147.23633-1-o.rempel@pengutronix.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Oct 2019 09:03:23 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Oleksij Rempel Date: Tue, 1 Oct 2019 08:41:47 +0200 > @@ -571,7 +571,9 @@ static int ag71xx_mdio_probe(struct ag71xx *ag) > msleep(200); > } > > - err = of_mdiobus_register(mii_bus, np); > + mnp = of_get_child_by_name(np, "mdio"); > + err = of_mdiobus_register(mii_bus, mnp); of_get_child_by_name() can fail, so error checking is necessary before you pass mnp into of_mdiobus_register().