netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: icenowy@aosc.io
Cc: robh+dt@kernel.org, mark.rutland@arm.com, mripard@kernel.org,
	wens@csie.org, andrew@lunn.ch, f.fainelli@gmail.com,
	hkallweit1@gmail.com, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH 0/3] Pine64+ specific hacks for RTL8211E Ethernet PHY
Date: Tue, 01 Oct 2019 09:06:51 -0700 (PDT)	[thread overview]
Message-ID: <20191001.090651.796983023328992596.davem@davemloft.net> (raw)
In-Reply-To: <20191001082912.12905-1-icenowy@aosc.io>

From: Icenowy Zheng <icenowy@aosc.io>
Date: Tue,  1 Oct 2019 16:29:09 +0800

> There're some Pine64+ boards known to have broken RTL8211E chips, and
> a hack is given by Pine64+, which is said to be from Realtek.
> 
> This patchset adds the hack.
> 
> The hack is taken from U-Boot, and it contains magic numbers without
> any document.

Please contact Realtek and try to get an explanation about this.

I understand that eventually we may not get a proper explanation
but I really want you to put forth real effort to nail down whats
going on here before I even consider these patches seriously.

Thank you.

  parent reply	other threads:[~2019-10-01 16:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01  8:29 [PATCH 0/3] Pine64+ specific hacks for RTL8211E Ethernet PHY Icenowy Zheng
2019-10-01  8:29 ` [PATCH 1/3] dt-bindings: add binding " Icenowy Zheng
2019-10-01  8:29 ` [PATCH 2/3] net: phy: realtek: add config hack for broken RTL8211E on Pine64+ boards Icenowy Zheng
2019-10-01  8:29 ` [PATCH 3/3] arm64: allwinner: a64: dts: apply hack for RTL8211E on Pine64+ Icenowy Zheng
2019-10-01 16:06 ` David Miller [this message]
2019-10-01 16:08   ` [PATCH 0/3] Pine64+ specific hacks for RTL8211E Ethernet PHY Icenowy Zheng
2019-10-01 16:30     ` David Miller
2019-10-01 16:31       ` Icenowy Zheng
2019-10-01 16:41         ` David Miller
2019-10-01 16:47 ` Florian Fainelli
2019-10-01 16:52   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191001.090651.796983023328992596.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=mripard@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).