From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 281DAC352AA for ; Tue, 1 Oct 2019 16:16:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00FCD20679 for ; Tue, 1 Oct 2019 16:16:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732247AbfJAQQk (ORCPT ); Tue, 1 Oct 2019 12:16:40 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49132 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731362AbfJAQQj (ORCPT ); Tue, 1 Oct 2019 12:16:39 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 23E94154A807D; Tue, 1 Oct 2019 09:16:39 -0700 (PDT) Date: Tue, 01 Oct 2019 09:16:38 -0700 (PDT) Message-Id: <20191001.091638.1225423650064491230.davem@davemloft.net> To: pmalani@chromium.org Cc: hayeswang@realtek.com, grundler@chromium.org, netdev@vger.kernel.org, nic_swsd@realtek.com Subject: Re: [PATCH net-next] r8152: Factor out OOB link list waits From: David Miller In-Reply-To: <20191001083556.195271-1-pmalani@chromium.org> References: <20191001083556.195271-1-pmalani@chromium.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Oct 2019 09:16:39 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Prashant Malani Date: Tue, 1 Oct 2019 01:35:57 -0700 > The same for-loop check for the LINK_LIST_READY bit of an OOB_CTRL > register is used in several places. Factor these out into a single > function to reduce the lines of code. > > Change-Id: I20e8f327045a72acc0a83e2d145ae2993ab62915 > Signed-off-by: Prashant Malani > Reviewed-by: Grant Grundler Applied.