From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB241C352AA for ; Tue, 1 Oct 2019 16:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FC102086A for ; Tue, 1 Oct 2019 16:26:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729792AbfJAQ0u (ORCPT ); Tue, 1 Oct 2019 12:26:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49324 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729188AbfJAQ0u (ORCPT ); Tue, 1 Oct 2019 12:26:50 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1F77A154B4BA3; Tue, 1 Oct 2019 09:26:50 -0700 (PDT) Date: Tue, 01 Oct 2019 09:26:49 -0700 (PDT) Message-Id: <20191001.092649.1794389127329635974.davem@davemloft.net> To: jcfaracco@gmail.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH v2] net: core: dev: replace state xoff flag comparison by netif_xmit_stopped method From: David Miller In-Reply-To: <20191001143904.6549-1-jcfaracco@gmail.com> References: <20191001143904.6549-1-jcfaracco@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Oct 2019 09:26:50 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: jcfaracco@gmail.com Date: Tue, 1 Oct 2019 11:39:04 -0300 > From: Julio Faracco > > Function netif_schedule_queue() has a hardcoded comparison between queue > state and any xoff flag. This comparison does the same thing as method > netif_xmit_stopped(). In terms of code clarity, it is better. See other > methods like: generic_xdp_tx() and dev_direct_xmit(). > > Signed-off-by: Julio Faracco Applied to net-next. Please explicitly put "[PATCH net-next v2]" 'net-next' in your Subject lines in the future.