> On Tue, 01 Oct 2019 13:06:36 +0200 > Toke Høiland-Jørgensen wrote: > > > Maciej Fijalkowski writes: > > > > > On Tue, 1 Oct 2019 11:24:43 +0200 > > > Lorenzo Bianconi wrote: > > > > > >> Add basic XDP support to mvneta driver for devices that rely on software > > >> buffer management. Currently supported verdicts are: > > >> - XDP_DROP > > >> - XDP_PASS > > >> - XDP_REDIRECT > > > > > > You're supporting XDP_ABORTED as well :P any plans for XDP_TX? > > > > Wait, if you are supporting REDIRECT but not TX, that means redirect > > only works to other, non-mvneta, devices, right? Maybe that should be > > made clear in the commit message :) > > If you implemented XDP_REDIRECT, then it should be trivial to implement > XDP_TX, as you can just convert the xdp_buff to xdp_frame and call your > ndo_xdp_xmit function directly (and do the tail-flush). > > Or maybe you are missing a ndo_xdp_xmit function (as Toke indirectly > points out). Hi Jesper and Toke, my plan is to add XDP_TX before posting a formal series (I am working on it). I shared this RFC series to get some comments and share the current status. Regards, Lorenzo > > -- > Best regards, > Jesper Dangaard Brouer > MSc.CS, Principal Kernel Engineer at Red Hat > LinkedIn: http://www.linkedin.com/in/brouer