From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED94ECE58A for ; Tue, 1 Oct 2019 13:40:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3B3920815 for ; Tue, 1 Oct 2019 13:40:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388636AbfJANkC (ORCPT ); Tue, 1 Oct 2019 09:40:02 -0400 Received: from relay-b02.edpnet.be ([212.71.1.222]:34888 "EHLO relay-b02.edpnet.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbfJANkB (ORCPT ); Tue, 1 Oct 2019 09:40:01 -0400 X-ASG-Debug-ID: 1569937198-0a7b8d53c1e88220001-BZBGGp Received: from zotac.vandijck-laurijssen.be (77.109.119.18.adsl.dyn.edpnet.net [77.109.119.18]) by relay-b02.edpnet.be with ESMTP id IODp9MwrRJmoWr37; Tue, 01 Oct 2019 15:39:58 +0200 (CEST) X-Barracuda-Envelope-From: dev.kurt@vandijck-laurijssen.be X-Barracuda-Effective-Source-IP: 77.109.119.18.adsl.dyn.edpnet.net[77.109.119.18] X-Barracuda-Apparent-Source-IP: 77.109.119.18 Received: from x1.vandijck-laurijssen.be (74.250-240-81.adsl-static.isp.belgacom.be [81.240.250.74]) by zotac.vandijck-laurijssen.be (Postfix) with ESMTPSA id 555E6A1ED6B; Tue, 1 Oct 2019 15:39:57 +0200 (CEST) Date: Tue, 1 Oct 2019 15:39:56 +0200 From: Kurt Van Dijck To: Jeroen Hofstee Cc: "linux-can@vger.kernel.org" , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , "open list:NETWORKING DRIVERS" , open list Subject: Re: [PATCH 1/2] can: D_CAN: perform a sofware reset on open Message-ID: <20191001133956.GB32369@x1.vandijck-laurijssen.be> X-ASG-Orig-Subj: Re: [PATCH 1/2] can: D_CAN: perform a sofware reset on open Mail-Followup-To: Jeroen Hofstee , "linux-can@vger.kernel.org" , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , "open list:NETWORKING DRIVERS" , open list References: <20190926085005.24805-1-jhofstee@victronenergy.com> <20190926085005.24805-2-jhofstee@victronenergy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190926085005.24805-2-jhofstee@victronenergy.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-Barracuda-Connect: 77.109.119.18.adsl.dyn.edpnet.net[77.109.119.18] X-Barracuda-Start-Time: 1569937198 X-Barracuda-URL: https://212.71.1.222:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at edpnet.be X-Barracuda-Scan-Msg-Size: 627 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: SPAM GLOBAL 0.9475 1.0000 3.7440 X-Barracuda-Spam-Score: 4.74 X-Barracuda-Spam-Status: No, SCORE=4.74 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=7.0 tests=BSF_SC2_SA016_OB X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.77000 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 1.00 BSF_SC2_SA016_OB Custom Rule SA016_OB Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On do, 26 sep 2019 08:50:44 +0000, Jeroen Hofstee wrote: > When the C_CAN interface is closed it is put in power down mode, but > does not reset the error counters / state. So reset the D_CAN on open, > so the reported state and the actual state match. > > According to [1], the C_CAN module doesn't have the software reset. > > [1] http://www.bosch-semiconductors.com/media/ip_modules/pdf_2/c_can_fd8/users_manual_c_can_fd8_r210_1.pdf > > Signed-off-by: Jeroen Hofstee I observed no problems after applying the patch. Tested-by: Kurt Van Dijck