From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA6EC35280 for ; Wed, 2 Oct 2019 15:47:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D814C21848 for ; Wed, 2 Oct 2019 15:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728964AbfJBPr3 (ORCPT ); Wed, 2 Oct 2019 11:47:29 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33118 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbfJBPr2 (ORCPT ); Wed, 2 Oct 2019 11:47:28 -0400 Received: from localhost (unknown [172.58.43.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 94C4214D07211; Wed, 2 Oct 2019 08:47:25 -0700 (PDT) Date: Wed, 02 Oct 2019 11:47:09 -0400 (EDT) Message-Id: <20191002.114709.1902747897923909745.davem@davemloft.net> To: jiri@resnulli.us Cc: netdev@vger.kernel.org, idosch@mellanox.com, pabeni@redhat.com, edumazet@google.com, petrm@mellanox.com, sd@queasysnail.net, f.fainelli@gmail.com, stephen@networkplumber.org, mlxsw@mellanox.com, andrew@lunn.ch Subject: Re: [patch net-next 2/3] net: introduce per-netns netdevice notifiers From: David Miller In-Reply-To: <20190930081511.26915-3-jiri@resnulli.us> References: <20190930081511.26915-1-jiri@resnulli.us> <20190930081511.26915-3-jiri@resnulli.us> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 02 Oct 2019 08:47:28 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Date: Mon, 30 Sep 2019 10:15:10 +0200 > From: Jiri Pirko > > Often the code for example in drivers is interested in getting notifier > call only from certain network namespace. In addition to the existing > global netdevice notifier chain introduce per-netns chains and allow > users to register to that. Eventually this would eliminate unnecessary > overhead in case there are many netdevices in many network namespaces. > > Signed-off-by: Jiri Pirko Ok, so there was a discussion about stop semantics. Honestly, I think that's fine. Stop means the operation cannot be performed and whoever is firing off the notifier will have to fail and undo the config change being attempted. In that context, it doesn't matter who or where in the chain we trigger the stop. Given all of that I am pretty sure this change is fine and I will add it to net-next. We can fix any actual semantic problems this might introduce as a follow-on.