From: David Miller <davem@davemloft.net>
To: linus.walleij@linaro.org
Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: rtl8366: Check VLAN ID and not ports
Date: Wed, 02 Oct 2019 12:10:04 -0400 (EDT) [thread overview]
Message-ID: <20191002.121004.2212668620537376356.davem@davemloft.net> (raw)
In-Reply-To: <20191001142843.10746-1-linus.walleij@linaro.org>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Tue, 1 Oct 2019 16:28:43 +0200
> There has been some confusion between the port number and
> the VLAN ID in this driver. What we need to check for
> validity is the VLAN ID, nothing else.
>
> The current confusion came from assigning a few default
> VLANs for default routing and we need to rewrite that
> properly.
>
> Instead of checking if the port number is a valid VLAN
> ID, check the actual VLAN IDs passed in to the callback
> one by one as expected.
>
> Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2019-10-02 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 14:28 [PATCH] net: dsa: rtl8366: Check VLAN ID and not ports Linus Walleij
2019-10-02 16:10 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-27 16:39 Linus Walleij
2019-09-27 16:40 ` Florian Fainelli
2019-09-28 20:26 ` Linus Walleij
2019-09-28 20:36 ` Florian Fainelli
2019-09-28 20:43 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002.121004.2212668620537376356.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).