netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] net/rds: Fix error handling in rds_ib_add_one()
@ 2019-10-01 17:21 Sudhakar Dindukurti
  2019-10-01 17:47 ` santosh.shilimkar
  2019-10-02 16:18 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Sudhakar Dindukurti @ 2019-10-01 17:21 UTC (permalink / raw)
  To: netdev, davem, santosh.shilimkar, rds-devel
  Cc: Dotan Barak, Sudhakar Dindukurti

From: Dotan Barak <dotanb@dev.mellanox.co.il>

rds_ibdev:ipaddr_list and rds_ibdev:conn_list are initialized
after allocation some resources such as protection domain.
If allocation of such resources fail, then these uninitialized
variables are accessed in rds_ib_dev_free() in failure path. This
can potentially crash the system. The code has been updated to
initialize these variables very early in the function.

Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
Signed-off-by: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>
---
 net/rds/ib.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/rds/ib.c b/net/rds/ib.c
index 45acab2..9de2ae2 100644
--- a/net/rds/ib.c
+++ b/net/rds/ib.c
@@ -143,6 +143,9 @@ static void rds_ib_add_one(struct ib_device *device)
 	refcount_set(&rds_ibdev->refcount, 1);
 	INIT_WORK(&rds_ibdev->free_work, rds_ib_dev_free);
 
+	INIT_LIST_HEAD(&rds_ibdev->ipaddr_list);
+	INIT_LIST_HEAD(&rds_ibdev->conn_list);
+
 	rds_ibdev->max_wrs = device->attrs.max_qp_wr;
 	rds_ibdev->max_sge = min(device->attrs.max_send_sge, RDS_IB_MAX_SGE);
 
@@ -203,9 +206,6 @@ static void rds_ib_add_one(struct ib_device *device)
 		device->name,
 		rds_ibdev->use_fastreg ? "FRMR" : "FMR");
 
-	INIT_LIST_HEAD(&rds_ibdev->ipaddr_list);
-	INIT_LIST_HEAD(&rds_ibdev->conn_list);
-
 	down_write(&rds_ib_devices_lock);
 	list_add_tail_rcu(&rds_ibdev->list, &rds_ib_devices);
 	up_write(&rds_ib_devices_lock);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] net/rds: Fix error handling in rds_ib_add_one()
  2019-10-01 17:21 [PATCH net] net/rds: Fix error handling in rds_ib_add_one() Sudhakar Dindukurti
@ 2019-10-01 17:47 ` santosh.shilimkar
  2019-10-02 16:18 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: santosh.shilimkar @ 2019-10-01 17:47 UTC (permalink / raw)
  To: Sudhakar Dindukurti, netdev, davem, rds-devel; +Cc: Dotan Barak

On 10/1/19 10:21 AM, Sudhakar Dindukurti wrote:
> From: Dotan Barak <dotanb@dev.mellanox.co.il>
> 
> rds_ibdev:ipaddr_list and rds_ibdev:conn_list are initialized
> after allocation some resources such as protection domain.
> If allocation of such resources fail, then these uninitialized
> variables are accessed in rds_ib_dev_free() in failure path. This
> can potentially crash the system. The code has been updated to
> initialize these variables very early in the function.
> 
> Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
> Signed-off-by: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>
> ---
Thanks Sudhakar !!

Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] net/rds: Fix error handling in rds_ib_add_one()
  2019-10-01 17:21 [PATCH net] net/rds: Fix error handling in rds_ib_add_one() Sudhakar Dindukurti
  2019-10-01 17:47 ` santosh.shilimkar
@ 2019-10-02 16:18 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-10-02 16:18 UTC (permalink / raw)
  To: sudhakar.dindukurti; +Cc: netdev, santosh.shilimkar, rds-devel, dotanb

From: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>
Date: Tue,  1 Oct 2019 10:21:02 -0700

> From: Dotan Barak <dotanb@dev.mellanox.co.il>
> 
> rds_ibdev:ipaddr_list and rds_ibdev:conn_list are initialized
> after allocation some resources such as protection domain.
> If allocation of such resources fail, then these uninitialized
> variables are accessed in rds_ib_dev_free() in failure path. This
> can potentially crash the system. The code has been updated to
> initialize these variables very early in the function.
> 
> Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
> Signed-off-by: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-02 16:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 17:21 [PATCH net] net/rds: Fix error handling in rds_ib_add_one() Sudhakar Dindukurti
2019-10-01 17:47 ` santosh.shilimkar
2019-10-02 16:18 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).