From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642F4C352AA for ; Wed, 2 Oct 2019 16:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D90521920 for ; Wed, 2 Oct 2019 16:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726458AbfJBQVX (ORCPT ); Wed, 2 Oct 2019 12:21:23 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33780 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725893AbfJBQVX (ORCPT ); Wed, 2 Oct 2019 12:21:23 -0400 Received: from localhost (unknown [172.58.43.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 21FB81540A47B; Wed, 2 Oct 2019 09:21:22 -0700 (PDT) Date: Wed, 02 Oct 2019 12:21:18 -0400 (EDT) Message-Id: <20191002.122118.97058861403796789.davem@davemloft.net> To: olteanv@gmail.com Cc: richardcochran@gmail.com, yangbo.lu@nxp.com, netdev@vger.kernel.org Subject: Re: [PATCH v2 net] ptp_qoriq: Initialize the registers' spinlock before calling ptp_qoriq_settime From: David Miller In-Reply-To: <20191001190701.5754-1-olteanv@gmail.com> References: <20191001190701.5754-1-olteanv@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 02 Oct 2019 09:21:23 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean Date: Tue, 1 Oct 2019 22:07:01 +0300 > Because ptp_qoriq_settime is being called prior to spin_lock_init, the > following stack trace can be seen at driver probe time: ... > Fixes: ff54571a747b ("ptp_qoriq: convert to use ptp_qoriq_init/free") > Signed-off-by: Vladimir Oltean Applied and queued up for -stable.