* [PATCH 1/3] Clean up the net/caif/Kconfig menu
2019-10-01 23:03 [PATCH 0/3] CAIF Kconfig fixes rd.dunlab
@ 2019-10-01 23:03 ` rd.dunlab
2019-10-01 23:04 ` [PATCH 2/3] Isolate CAIF transport drivers into their own menu rd.dunlab
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: rd.dunlab @ 2019-10-01 23:03 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, rdunlap
[-- Attachment #1: net-caif-Kconfig-clean001.patch --]
[-- Type: text/plain, Size: 1723 bytes --]
Clean up the net/caif/Kconfig menu:
- remove extraneous space
- minor language tweaks
- fix punctuation
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
---
net/caif/Kconfig | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- lnx-53-caif.orig/net/caif/Kconfig
+++ lnx-53-caif/net/caif/Kconfig
@@ -13,11 +13,11 @@ menuconfig CAIF
with its modems. It is accessed from user space as sockets (PF_CAIF).
Say Y (or M) here if you build for a phone product (e.g. Android or
- MeeGo ) that uses CAIF as transport, if unsure say N.
+ MeeGo) that uses CAIF as transport. If unsure say N.
If you select to build it as module then CAIF_NETDEV also needs to be
- built as modules. You will also need to say yes to any CAIF physical
- devices that your platform requires.
+ built as a module. You will also need to say Y (or M) to any CAIF
+ physical devices that your platform requires.
See Documentation/networking/caif for a further explanation on how to
use and configure CAIF.
@@ -37,7 +37,7 @@ config CAIF_NETDEV
default CAIF
---help---
Say Y if you will be using a CAIF based GPRS network device.
- This can be either built-in or a loadable module,
+ This can be either built-in or a loadable module.
If you select to build it as a built-in then the main CAIF device must
also be a built-in.
If unsure say Y.
@@ -48,7 +48,7 @@ config CAIF_USB
default n
---help---
Say Y if you are using CAIF over USB CDC NCM.
- This can be either built-in or a loadable module,
+ This can be either built-in or a loadable module.
If you select to build it as a built-in then the main CAIF device must
also be a built-in.
If unsure say N.
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/3] Isolate CAIF transport drivers into their own menu
2019-10-01 23:03 [PATCH 0/3] CAIF Kconfig fixes rd.dunlab
2019-10-01 23:03 ` [PATCH 1/3] Clean up the net/caif/Kconfig menu rd.dunlab
@ 2019-10-01 23:04 ` rd.dunlab
2019-10-01 23:04 ` [PATCH 3/3] Minor fixes to the CAIF Transport drivers Kconfig file rd.dunlab
2019-10-02 21:48 ` [PATCH 0/3] CAIF Kconfig fixes David Miller
3 siblings, 0 replies; 5+ messages in thread
From: rd.dunlab @ 2019-10-01 23:04 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, rdunlap
[-- Attachment #1: drv-net-caif-menu.patch --]
[-- Type: text/plain, Size: 892 bytes --]
Isolate CAIF transport drivers into their own menu.
This cleans up the main Network device support menu,
makes it easier to find the CAIF drivers, and makes it
easier to enable/disable them as a group.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
---
drivers/net/caif/Kconfig | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
--- lnx-53-caif.orig/drivers/net/caif/Kconfig
+++ lnx-53-caif/drivers/net/caif/Kconfig
@@ -3,7 +3,13 @@
# CAIF physical drivers
#
-comment "CAIF transport drivers"
+menuconfig CAIF_DRIVERS
+ bool "CAIF transport drivers"
+ depends on CAIF
+ help
+ Enable this to see CAIF physical drivers.
+
+if CAIF_DRIVERS
config CAIF_TTY
tristate "CAIF TTY transport driver"
@@ -55,3 +61,5 @@ config CAIF_VIRTIO
if CAIF_VIRTIO
source "drivers/vhost/Kconfig.vringh"
endif
+
+endif # CAIF_DRIVERS
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] Minor fixes to the CAIF Transport drivers Kconfig file
2019-10-01 23:03 [PATCH 0/3] CAIF Kconfig fixes rd.dunlab
2019-10-01 23:03 ` [PATCH 1/3] Clean up the net/caif/Kconfig menu rd.dunlab
2019-10-01 23:04 ` [PATCH 2/3] Isolate CAIF transport drivers into their own menu rd.dunlab
@ 2019-10-01 23:04 ` rd.dunlab
2019-10-02 21:48 ` [PATCH 0/3] CAIF Kconfig fixes David Miller
3 siblings, 0 replies; 5+ messages in thread
From: rd.dunlab @ 2019-10-01 23:04 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, rdunlap
[-- Attachment #1: drv-net-caif-Kconfig-clean002.patch --]
[-- Type: text/plain, Size: 1361 bytes --]
Minor fixes to the CAIF Transport drivers Kconfig file:
- end sentence with period
- capitalize CAIF acronym
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
---
drivers/net/caif/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- lnx-53-caif.orig/drivers/net/caif/Kconfig
+++ lnx-53-caif/drivers/net/caif/Kconfig
@@ -28,7 +28,7 @@ config CAIF_SPI_SLAVE
The CAIF Link layer SPI Protocol driver for Slave SPI interface.
This driver implements a platform driver to accommodate for a
platform specific SPI device. A sample CAIF SPI Platform device is
- provided in Documentation/networking/caif/spi_porting.txt
+ provided in <file:Documentation/networking/caif/spi_porting.txt>.
config CAIF_SPI_SYNC
bool "Next command and length in start of frame"
@@ -44,7 +44,7 @@ config CAIF_HSI
depends on CAIF
default n
---help---
- The caif low level driver for CAIF over HSI.
+ The CAIF low level driver for CAIF over HSI.
Be aware that if you enable this then you also need to
enable a low-level HSI driver.
@@ -56,7 +56,7 @@ config CAIF_VIRTIO
select GENERIC_ALLOCATOR
default n
---help---
- The caif driver for CAIF over Virtio.
+ The CAIF driver for CAIF over Virtio.
if CAIF_VIRTIO
source "drivers/vhost/Kconfig.vringh"
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 0/3] CAIF Kconfig fixes
2019-10-01 23:03 [PATCH 0/3] CAIF Kconfig fixes rd.dunlab
` (2 preceding siblings ...)
2019-10-01 23:04 ` [PATCH 3/3] Minor fixes to the CAIF Transport drivers Kconfig file rd.dunlab
@ 2019-10-02 21:48 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2019-10-02 21:48 UTC (permalink / raw)
To: rd.dunlab; +Cc: netdev, rdunlap
From: rd.dunlab@gmail.com
Date: Tue, 01 Oct 2019 16:03:58 -0700
>
> This series of patches cleans up the CAIF Kconfig menus in
> net/caif/Kconfig and drivers/net/caif/Kconfig and also puts the
> CAIF Transport drivers into their own sub-menu.
Series applied to net-next. Please fix your From: field in future
submissions, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread