From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35746C352AA for ; Wed, 2 Oct 2019 08:56:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1180321920 for ; Wed, 2 Oct 2019 08:56:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727218AbfJBI4A (ORCPT ); Wed, 2 Oct 2019 04:56:00 -0400 Received: from www62.your-server.de ([213.133.104.62]:39636 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725852AbfJBIz7 (ORCPT ); Wed, 2 Oct 2019 04:55:59 -0400 Received: from [2a02:120b:2c12:c120:71a0:62dd:894c:fd0e] (helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iFaQL-0004eR-MZ; Wed, 02 Oct 2019 10:55:53 +0200 Date: Wed, 2 Oct 2019 10:55:53 +0200 From: Daniel Borkmann To: Brian Vazquez Cc: Andrii Nakryiko , Brian Vazquez , Alexei Starovoitov , "David S . Miller" , Stanislav Fomichev , open list , Networking , bpf Subject: Re: [PATCH bpf 2/2] selftests/bpf: test_progs: don't leak server_fd in test_sockopt_inherit Message-ID: <20191002085553.GA6226@pc-66.home> References: <20191001173728.149786-1-brianvv@google.com> <20191001173728.149786-3-brianvv@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25589/Tue Oct 1 10:30:33 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 01, 2019 at 08:42:30PM -0700, Brian Vazquez wrote: > Thanks for reviewing the patches Andrii! > > Although Daniel fixed them and applied them correctly. After last kernel/maintainer summit at LPC, I reworked all my patchwork scripts [0] which I use for bpf trees in order to further reduce manual work and add more sanity checks at the same time. Therefore, the broken Fixes: tag was a good test-case. ;-) Thanks, Daniel [0] https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/pw.git/ > On Tue, Oct 1, 2019 at 8:20 PM Andrii Nakryiko > wrote: > > > > On Tue, Oct 1, 2019 at 10:40 AM Brian Vazquez wrote: > > > > > > > I don't think there is a need to add "test_progs:" to subject, " > > test_sockopt_inherit" is specific enough ;) > > > > > server_fd needs to be close if pthread can't be created. > > > > typo: closed > > > > > Fixes: e3e02e1d9c24 ("selftests/bpf: test_progs: convert test_sockopt_inherit") > > > Cc: Stanislav Fomichev > > > Signed-off-by: Brian Vazquez > > > --- > > > > Acked-by: Andrii Nakryiko > > > > > tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-)