netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Julia Kartseva" <hex@fb.com>, "Yonghong Song" <yhs@fb.com>,
	"debian-kernel@lists.debian.org" <debian-kernel@lists.debian.org>,
	"md@linux.it" <md@linux.it>, "Alexei Starovoitov" <ast@fb.com>,
	"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
	"labbott@redhat.com" <labbott@redhat.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Andrey Ignatov" <rdna@fb.com>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Jesper Dangaard Brouer" <brouer@redhat.com>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	iovisor-dev@lists.iovisor.org
Subject: Re: libbpf-devel rpm uapi headers
Date: Wed, 2 Oct 2019 11:43:17 -0700	[thread overview]
Message-ID: <20191002184315.zl5xpfhsaspllaix@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20191002174331.GA13941@krava>

On Wed, Oct 02, 2019 at 07:43:31PM +0200, Jiri Olsa wrote:
> hi,
> we'd like to have bcc linked with libbpf instead of the
> github submodule, initial change is discussed in here:
>   https://github.com/iovisor/bcc/pull/2535
> 
> In order to do that, we need to have access to uapi headers
> compatible with libbpf rpm, bcc is attaching and using them
> during compilation.
> 
> I added them in the fedora spec below (not submitted yet),
> so libbpf would carry those headers.
> 
> Thoughts? thanks,

I think it may break a bunch of people who rely on bcc being a single library.
What is the main motiviation to use libbpf as a shared library in libbcc?

I think we can have both options. libbpf as git submodule and as shared.
In practice git submodule is so much simpler to use and a lot less headaches.


  reply	other threads:[~2019-10-02 18:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 17:43 Jiri Olsa
2019-10-02 18:43 ` Alexei Starovoitov [this message]
2019-10-02 20:08   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002184315.zl5xpfhsaspllaix@ast-mbp.dhcp.thefacebook.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=acme@kernel.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@fb.com \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=debian-kernel@lists.debian.org \
    --cc=hex@fb.com \
    --cc=iovisor-dev@lists.iovisor.org \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=labbott@redhat.com \
    --cc=md@linux.it \
    --cc=netdev@vger.kernel.org \
    --cc=rdna@fb.com \
    --cc=toke@redhat.com \
    --cc=yhs@fb.com \
    --subject='Re: libbpf-devel rpm uapi headers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).