From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C05C32792 for ; Thu, 3 Oct 2019 15:49:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A506520700 for ; Thu, 3 Oct 2019 15:49:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729582AbfJCPty (ORCPT ); Thu, 3 Oct 2019 11:49:54 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:45196 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727024AbfJCPty (ORCPT ); Thu, 3 Oct 2019 11:49:54 -0400 Received: from localhost (unknown [IPv6:2603:3023:50c:85e1:b5c5:ae11:3e54:6a07]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C15121433FC57; Thu, 3 Oct 2019 08:49:53 -0700 (PDT) Date: Thu, 03 Oct 2019 11:49:52 -0400 (EDT) Message-Id: <20191003.114952.2201613708507386478.davem@davemloft.net> To: johunt@akamai.com Cc: netdev@vger.kernel.org, edumazet@google.com, willemb@google.com, alexander.h.duyck@intel.com Subject: Re: [PATCH net v2 1/2] udp: fix gso_segs calculations From: David Miller In-Reply-To: <1570037363-12485-1-git-send-email-johunt@akamai.com> References: <1570037363-12485-1-git-send-email-johunt@akamai.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 03 Oct 2019 08:49:54 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Josh Hunt Date: Wed, 2 Oct 2019 13:29:22 -0400 > Commit dfec0ee22c0a ("udp: Record gso_segs when supporting UDP segmentation offload") > added gso_segs calculation, but incorrectly got sizeof() the pointer and > not the underlying data type. In addition let's fix the v6 case. > > Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT") > Fixes: dfec0ee22c0a ("udp: Record gso_segs when supporting UDP segmentation offload") > Signed-off-by: Josh Hunt > Reviewed-by: Alexander Duyck > Acked-by: Willem de Bruijn Applied and queued up for -stable.