From: David Miller <davem@davemloft.net>
To: pmalani@chromium.org
Cc: hayeswang@realtek.com, grundler@chromium.org,
netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH net-next] r8152: Add identifier names for function pointers
Date: Thu, 03 Oct 2019 11:51:11 -0400 (EDT) [thread overview]
Message-ID: <20191003.115111.1102308654924030394.davem@davemloft.net> (raw)
In-Reply-To: <20191002210933.122122-1-pmalani@chromium.org>
From: Prashant Malani <pmalani@chromium.org>
Date: Wed, 2 Oct 2019 14:09:33 -0700
> Checkpatch throws warnings for function pointer declarations which lack
> identifier names.
>
> An example of such a warning is:
>
> WARNING: function definition argument 'struct r8152 *' should
> also have an identifier name
> 739: FILE: drivers/net/usb/r8152.c:739:
> + void (*init)(struct r8152 *);
>
> So, fix those warnings by adding the identifier names.
>
> While we are at it, also fix a character limit violation which was
> causing another checkpatch warning.
>
> Change-Id: Idec857ce2dc9592caf3173188be1660052c052ce
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> Reviewed-by: Grant Grundler <grundler@chromium.org>
Applied.
prev parent reply other threads:[~2019-10-03 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 21:09 [PATCH net-next] r8152: Add identifier names for function pointers Prashant Malani
2019-10-03 2:03 ` Hayes Wang
2019-10-03 15:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003.115111.1102308654924030394.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=grundler@chromium.org \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).