From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, idosch@mellanox.com, dsahern@gmail.com,
jakub.kicinski@netronome.com, tariqt@mellanox.com,
saeedm@mellanox.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, shuah@kernel.org, mlxsw@mellanox.com
Subject: Re: [patch net-next v3 00/15] devlink: allow devlink instances to change network namespace
Date: Fri, 04 Oct 2019 11:11:33 -0700 (PDT) [thread overview]
Message-ID: <20191004.111133.1035307264097392906.davem@davemloft.net> (raw)
In-Reply-To: <20191003094940.9797-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 3 Oct 2019 11:49:25 +0200
> Devlink from the beginning counts with network namespaces, but the
> instances has been fixed to init_net.
>
> Implement change of network namespace as part of "devlink reload"
> procedure like this:
>
> $ ip netns add testns1
> $ devlink/devlink dev reload netdevsim/netdevsim10 netns testns1
>
> This command reloads device "netdevsim10" into network
> namespace "testns1".
>
> Note that "devlink reload" reinstantiates driver objects, effectively it
> reloads the driver instance, including possible hw reset etc. Newly
> created netdevices respect the network namespace of the parent devlink
> instance and according to that, they are created in target network
> namespace.
>
> Driver is able to refuse to be reloaded into different namespace. That
> is the case of mlx4 right now.
>
> FIB entries and rules are replayed during FIB notifier registration
> which is triggered during reload (driver instance init). FIB notifier
> is also registered to the target network namespace, that allows user
> to use netdevsim devlink resources to setup per-namespace limits of FIB
> entries and FIB rules. In fact, with multiple netdevsim instances
> in each network namespace, user might setup different limits.
> This maintains and extends current netdevsim resources behaviour.
...
Series applied, thanks Jiri.
prev parent reply other threads:[~2019-10-04 18:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 9:49 [patch net-next v3 00/15] devlink: allow devlink instances to change network namespace Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 01/15] netdevsim: change fib accounting and limitations to be per-device Jiri Pirko
2019-10-03 23:03 ` Jakub Kicinski
2019-10-03 9:49 ` [patch net-next v3 02/15] net: fib_notifier: make FIB notifier per-netns Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 03/15] net: fib_notifier: propagate possible error during fib notifier registration Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 04/15] mlxsw: spectrum_router: Don't rely on missing extack to symbolize dump Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 05/15] net: fib_notifier: propagate extack down to the notifier block callback Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 06/15] net: devlink: export devlink net getter Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 07/15] mlxsw: spectrum: Take devlink net instead of init_net Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 08/15] mlxsw: Register port netdevices into net of core Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 09/15] mlxsw: Propagate extack down to register_fib_notifier() Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 10/15] netdevsim: add all ports in nsim_dev_create() and del them in destroy() Jiri Pirko
2019-10-03 23:07 ` Jakub Kicinski
2019-10-03 9:49 ` [patch net-next v3 11/15] netdevsim: implement proper devlink reload Jiri Pirko
2019-10-03 23:17 ` Jakub Kicinski
2019-10-04 6:19 ` Jiri Pirko
2019-10-04 17:42 ` Jakub Kicinski
2019-10-04 20:49 ` Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 12/15] netdevsim: register port netdevices into net of device Jiri Pirko
2019-10-03 23:21 ` Jakub Kicinski
2019-10-04 6:20 ` Jiri Pirko
2019-10-03 9:49 ` [patch net-next v3 13/15] netdevsim: take devlink net instead of init_net Jiri Pirko
2019-10-03 23:21 ` Jakub Kicinski
2019-10-03 9:49 ` [patch net-next v3 14/15] net: devlink: allow to change namespaces during reload Jiri Pirko
2019-10-03 23:23 ` Jakub Kicinski
2019-10-03 9:49 ` [patch net-next v3 15/15] selftests: netdevsim: add tests for devlink reload with resources Jiri Pirko
2019-10-03 9:51 ` [patch iproute2-next v3 1/2] devlink: introduce cmdline option to switch to a different namespace Jiri Pirko
2019-10-07 22:01 ` David Ahern
2019-10-03 9:51 ` [patch iproute2-next v3 2/2] devlink: extend reload command to add support for network namespace change Jiri Pirko
2019-10-04 18:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004.111133.1035307264097392906.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=kuznet@ms2.inr.ac.ru \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=shuah@kernel.org \
--cc=tariqt@mellanox.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).