From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA32C47404 for ; Fri, 4 Oct 2019 13:47:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52B9720700 for ; Fri, 4 Oct 2019 13:47:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="jNOBjg77"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ESd3wgaB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388876AbfJDNrh (ORCPT ); Fri, 4 Oct 2019 09:47:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51540 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388438AbfJDNrh (ORCPT ); Fri, 4 Oct 2019 09:47:37 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2D517619F4; Fri, 4 Oct 2019 13:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570196856; bh=YTbkcIOSoT6sfkliDWftlO8oLXWgzNqKOEziTUyn0HU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=jNOBjg77Md9jO1ArgJgRIulK23TEMZaqZ/JV6WLuLYPcAFqvLwYV/wrUhKsdbZa4+ w5LGElS3knZUK4dg6HW4O6t6a/0zSuO2ftehftqW3qQTHvWkSwaLXZ9pn86g47c82J HQLKAoo1QS7TwMt4KXNd4OicHVBiI7ipjxfJor+Q= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 28C4A6081C; Fri, 4 Oct 2019 13:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570196855; bh=YTbkcIOSoT6sfkliDWftlO8oLXWgzNqKOEziTUyn0HU=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=ESd3wgaBuhMt7Vw0LAcQG80pZLg82sIGccWfnpkFvmJvHKErgvVz/Gwg7OXZMo5M+ 2QkIUoWqLvWjT5dvTYuD+71vcJusxAhvcD6cEp3WP/XQEpGC9Nr0KI1Jot1RNOuFy3 7JvVAlt3hoq+UDbGBByU5Qq4YWhuDrZol0TMOWzM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 28C4A6081C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rsi: fix potential null dereference in rsi_probe() From: Kalle Valo In-Reply-To: <20191002171811.23993-1-efremov@linux.com> References: <20191002171811.23993-1-efremov@linux.com> To: Denis Efremov Cc: linux-wireless@vger.kernel.org, Denis Efremov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Amitkumar Karwar , Siva Rebbagondla User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191004134736.2D517619F4@smtp.codeaurora.org> Date: Fri, 4 Oct 2019 13:47:36 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Denis Efremov wrote: > The id pointer can be NULL in rsi_probe(). It is checked everywhere except > for the else branch in the idProduct condition. The patch adds NULL check > before the id dereference in the rsi_dbg() call. > > Fixes: 54fdb318c111 ("rsi: add new device model for 9116") > Cc: Amitkumar Karwar > Cc: Siva Rebbagondla > Cc: Kalle Valo > Signed-off-by: Denis Efremov Patch applied to wireless-drivers-next.git, thanks. f170d44bc4ec rsi: fix potential null dereference in rsi_probe() -- https://patchwork.kernel.org/patch/11171695/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches