From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v2 net-next 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.
Date: Fri, 4 Oct 2019 14:32:36 -0700 [thread overview]
Message-ID: <20191004143236.334e9e05@cakuba.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20191004210934.12813-3-andrew@lunn.ch>
On Fri, 4 Oct 2019 23:09:34 +0200, Andrew Lunn wrote:
> diff --git a/Documentation/networking/devlink-params-mv88e6xxx.txt b/Documentation/networking/devlink-params-mv88e6xxx.txt
> new file mode 100644
> index 000000000000..cc5c1ac87c36
> --- /dev/null
> +++ b/Documentation/networking/devlink-params-mv88e6xxx.txt
> @@ -0,0 +1,6 @@
> +ATU_hash [DEVICE, DRIVER-SPECIFIC]
> + Select one of four possible hashing algorithms for
> + MAC addresses in the Address Translation Unity.
> + A value of 3 seems to work better than the default of
> + 1 when many MAC addresses have the same OUI.
> + Configuration mode: runtime
I think it's common practice to specify the type here? Otherwise looks
good to me, thanks for adding it!
next prev parent reply other threads:[~2019-10-04 21:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 21:09 [PATCH v2 net-next 0/2] mv88e6xxx: Allow config of ATU hash algorithm Andrew Lunn
2019-10-04 21:09 ` [PATCH v2 net-next 1/2] net: dsa: Add support for devlink device parameters Andrew Lunn
2019-10-05 0:21 ` Vivien Didelot
2019-10-05 0:52 ` Andrew Lunn
2019-10-04 21:09 ` [PATCH v2 net-next 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm Andrew Lunn
2019-10-04 21:32 ` Jakub Kicinski [this message]
2019-10-04 21:40 ` Andrew Lunn
2019-10-05 0:32 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004143236.334e9e05@cakuba.hsd1.ca.comcast.net \
--to=jakub.kicinski@netronome.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).