From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jason Gunthorpe <jgg@mellanox.com>,
"dledford@redhat.com" <dledford@redhat.com>,
Mustafa Ismail <mustafa.ismail@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Shiraz Saleem <shiraz.saleem@intel.com>
Subject: Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions
Date: Sat, 5 Oct 2019 09:08:27 +0200 [thread overview]
Message-ID: <20191005070827.GA929891@kroah.com> (raw)
In-Reply-To: <20191005062805.GP5855@unreal>
On Sat, Oct 05, 2019 at 09:28:05AM +0300, Leon Romanovsky wrote:
> On Fri, Oct 04, 2019 at 05:46:15PM -0700, Jeff Kirsher wrote:
> > On Fri, 2019-10-04 at 23:45 +0000, Jason Gunthorpe wrote:
> > > On Fri, Oct 04, 2019 at 01:12:22PM -0700, Jeff Kirsher wrote:
> > >
> > > > > > + if (ldev->version.major != I40E_CLIENT_VERSION_MAJOR ||
> > > > > > + ldev->version.minor != I40E_CLIENT_VERSION_MINOR) {
> > > > > > + pr_err("version mismatch:\n");
> > > > > > + pr_err("expected major ver %d, caller specified
> > > > > > major
> > > > > > ver %d\n",
> > > > > > + I40E_CLIENT_VERSION_MAJOR, ldev-
> > > > > > >version.major);
> > > > > > + pr_err("expected minor ver %d, caller specified
> > > > > > minor
> > > > > > ver %d\n",
> > > > > > + I40E_CLIENT_VERSION_MINOR, ldev-
> > > > > > >version.minor);
> > > > > > + return -EINVAL;
> > > > > > + }
> > > > >
> > > > > This is can't be in upstream code, we don't support out-of-tree
> > > > > modules,
> > > > > everything else will have proper versions.
> > > >
> > > > Who is the "we" in this context?
> > >
> > > Upstream sensibility - if we start doing stuff like this then we will
> > > end up doing it everwhere.
> >
> > I see you cut out the part of my response about Linux distributions
> > disagreeing with this stance.
> >
> > >
> > > > you support out-of-tree drivers, they do exist and this code would
> > > > ensure that if a "out-of-tree" driver is loaded, the driver will do a
> > > > sanity check to ensure the RDMA driver will work.
> > >
> > > I don't see how this is any different from any of the other myriad of
> > > problems out of tree modules face.
> > >
> > > Someone providing out of tree modules has to provide enough parts of
> > > their driver so that it only consumes the stable ABI from the distro
> > > kernel.
> > >
> > > Pretty normal stuff really.
> >
> > Your right, if the dependency was reversed and the out-of-tree (OOT) driver
> > was dependent upon the RDMA driver, but in this case it is not. The LAN
> > driver does not "need" the RDMA driver to work. So the RDMA driver should
> > at least check that the LAN driver loaded has the required version to work.
>
> Not in upstream code, there is an expectation that kernel and modules are aligned.
s/expectation/requirement/
If you do not do that, all bets are off.
Distros can decide to do whatever they want with their kernels, but
that's not what we require upstream.
thanks,
greg k-h
next prev parent reply other threads:[~2019-10-05 7:08 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 16:44 [RFC 00/20] Intel RDMA/IDC Driver series Jeff Kirsher
2019-09-26 16:45 ` [RFC 01/20] ice: Initialize and register multi-function device to provide RDMA Jeff Kirsher
2019-09-26 18:05 ` Greg KH
2019-09-26 23:39 ` Nguyen, Anthony L
2019-09-27 5:13 ` gregkh
2019-09-27 18:03 ` Ertman, David M
2019-10-23 17:44 ` Jason Gunthorpe
2019-10-23 17:55 ` Ertman, David M
2019-10-23 18:01 ` Jason Gunthorpe
2019-10-24 18:56 ` gregkh
2019-10-24 19:10 ` Jason Gunthorpe
2019-10-24 22:25 ` Ertman, David M
2019-10-25 1:30 ` gregkh
2019-10-25 22:27 ` Ertman, David M
2019-10-26 18:53 ` gregkh
2019-10-31 7:42 ` Tomas Winkler
2019-09-26 16:45 ` [RFC 02/20] ice: Implement peer communications Jeff Kirsher
2019-09-26 16:45 ` [RFC 03/20] i40e: Register multi-function device to provide RDMA Jeff Kirsher
2019-09-26 16:45 ` [RFC 04/20] RDMA/irdma: Add driver framework definitions Jeff Kirsher
2019-09-26 16:55 ` Jason Gunthorpe
2019-09-26 18:02 ` gregkh
2019-09-26 18:04 ` Jason Gunthorpe
2019-09-26 18:10 ` Saleem, Shiraz
2019-09-26 17:30 ` Leon Romanovsky
2019-09-26 19:51 ` Saleem, Shiraz
2019-10-04 20:12 ` Jeff Kirsher
2019-10-04 23:45 ` Jason Gunthorpe
2019-10-05 0:46 ` Jeff Kirsher
2019-10-05 6:28 ` Leon Romanovsky
2019-10-05 7:08 ` gregkh [this message]
2019-10-05 22:01 ` Jason Gunthorpe
2019-09-26 16:45 ` [RFC 05/20] RDMA/irdma: Implement device initialization definitions Jeff Kirsher
2019-09-26 16:45 ` [RFC 06/20] RDMA/irdma: Implement HW Admin Queue OPs Jeff Kirsher
2019-09-26 16:45 ` [RFC 07/20] RDMA/irdma: Add HMC backing store setup functions Jeff Kirsher
2019-09-26 16:45 ` [RFC 08/20] RDMA/irdma: Add privileged UDA queue implementation Jeff Kirsher
2019-09-26 16:45 ` [RFC 09/20] RDMA/irdma: Add QoS definitions Jeff Kirsher
2019-09-26 16:45 ` [RFC 10/20] RDMA/irdma: Add connection manager Jeff Kirsher
2019-09-26 16:45 ` [RFC 11/20] RDMA/irdma: Add PBLE resource manager Jeff Kirsher
2019-09-26 16:45 ` [RFC 12/20] RDMA/irdma: Implement device supported verb APIs Jeff Kirsher
2019-09-26 17:37 ` Leon Romanovsky
2019-09-26 17:40 ` Jason Gunthorpe
2019-09-26 19:50 ` Saleem, Shiraz
2019-09-26 19:49 ` Saleem, Shiraz
2019-09-27 4:50 ` Leon Romanovsky
2019-09-27 14:28 ` Saleem, Shiraz
2019-09-28 6:00 ` Leon Romanovsky
2019-09-30 14:14 ` Saleem, Shiraz
2019-09-26 16:45 ` [RFC 13/20] RDMA/irdma: Add RoCEv2 UD OP support Jeff Kirsher
2019-09-26 16:45 ` [RFC 14/20] RDMA/irdma: Add user/kernel shared libraries Jeff Kirsher
2019-09-26 16:45 ` [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions Jeff Kirsher
2019-09-26 17:49 ` Leon Romanovsky
2019-09-26 19:49 ` Saleem, Shiraz
2019-09-27 4:46 ` Leon Romanovsky
2019-09-27 14:28 ` Saleem, Shiraz
2019-09-27 18:23 ` gregkh
2019-09-28 5:53 ` Leon Romanovsky
2019-09-26 16:45 ` [RFC 16/20] RDMA/irdma: Add dynamic tracing for CM Jeff Kirsher
2019-09-26 16:45 ` [RFC 17/20] RDMA/irdma: Add ABI definitions Jeff Kirsher
2019-09-26 16:45 ` [RFC 18/20] RDMA/irdma: Update MAINTAINERS file Jeff Kirsher
2019-09-26 16:45 ` [RFC 19/20] RDMA/irdma: Add Kconfig and Makefile Jeff Kirsher
2019-09-26 16:45 ` [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated Jeff Kirsher
2019-09-26 17:40 ` Leon Romanovsky
2019-09-26 19:49 ` Saleem, Shiraz
2019-09-26 19:55 ` gregkh
2019-09-27 14:28 ` Saleem, Shiraz
2019-09-27 20:18 ` Doug Ledford
2019-09-27 20:17 ` Doug Ledford
2019-09-28 5:55 ` Leon Romanovsky
2019-10-02 21:15 ` Dennis Dalessandro
2019-10-03 8:23 ` Leon Romanovsky
2019-09-29 9:28 ` [RFC 00/20] Intel RDMA/IDC Driver series Or Gerlitz
2019-09-30 15:46 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005070827.GA929891@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dledford@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).