From: Simon Horman <simon.horman@netronome.com>
To: Tom Herbert <tom@herbertland.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Tom Herbert <tom@quantonium.net>
Subject: Re: [PATCH v5 net-next 5/7] ip6tlvs: Add TX parameters
Date: Sun, 6 Oct 2019 15:25:48 +0200 [thread overview]
Message-ID: <20191006132547.stdd4hhj3y4dckqf@netronome.com> (raw)
In-Reply-To: <1570139884-20183-6-git-send-email-tom@herbertland.com>
On Thu, Oct 03, 2019 at 02:58:02PM -0700, Tom Herbert wrote:
> From: Tom Herbert <tom@quantonium.net>
>
> Define a number of transmit parameters for TLV Parameter table
> definitions. These will be used for validating TLVs that are set
> on a socket.
>
> Signed-off-by: Tom Herbert <tom@herbertland.com>
> ---
> include/net/ipeh.h | 18 ++++++++++++++++
> include/uapi/linux/ipeh.h | 8 +++++++
> net/ipv6/exthdrs_common.c | 53 +++++++++++++++++++++++++++++++++++++++++++++-
> net/ipv6/exthdrs_options.c | 45 +++++++++++++++++++++++++++++++++++++++
> 4 files changed, 123 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/ipeh.h b/include/net/ipeh.h
> index aaa2910..de6d9d0 100644
> --- a/include/net/ipeh.h
> +++ b/include/net/ipeh.h
...
> @@ -54,6 +65,13 @@ struct tlv_param_table {
>
> extern struct tlv_param_table ipv6_tlv_param_table;
>
> +/* Preferred TLV ordering for HBH and Dest options (placed by increasing order)
> + */
> +#define IPEH_TLV_PREF_ORDER_HAO 10
> +#define IPEH_TLV_PREF_ORDER_ROUTERALERT 20
> +#define IPEH_TLV_PREF_ORDER_JUMBO 30
> +#define IPEH_TLV_PREF_ORDER_CALIPSO 40
> +
Hi Tom,
Could you expand on why thse values were chosen?
I can see that this patch implements a specific use of
the 255 indexes available. But its not at all clear to me that
this use fits expected use-cases (because I don't know what they are).
...
next prev parent reply other threads:[~2019-10-06 13:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 21:57 [PATCH v5 net-next 0/7] ipv6: Extension header infrastructure Tom Herbert
2019-10-03 21:57 ` [PATCH v5 net-next 1/7] ipeh: Create exthdrs_options.c and ipeh.h Tom Herbert
2019-10-06 13:02 ` Simon Horman
2019-12-14 18:44 ` Tom Herbert
2019-10-03 21:57 ` [PATCH v5 net-next 2/7] ipeh: Move generic EH functions to exthdrs_common.c Tom Herbert
2019-10-06 13:00 ` Simon Horman
2019-12-14 18:47 ` Tom Herbert
2019-12-18 10:56 ` Simon Horman
2019-10-03 21:58 ` [PATCH v5 net-next 3/7] ipeh: Generic TLV parser Tom Herbert
2019-10-06 13:05 ` Simon Horman
2019-12-14 19:08 ` Tom Herbert
2019-10-03 21:58 ` [PATCH v5 net-next 4/7] ip6tlvs: Registration of TLV handlers and parameters Tom Herbert
2019-10-06 13:18 ` Simon Horman
2019-10-03 21:58 ` [PATCH v5 net-next 5/7] ip6tlvs: Add TX parameters Tom Herbert
2019-10-06 13:25 ` Simon Horman [this message]
2019-12-14 19:19 ` Tom Herbert
2019-10-03 21:58 ` [PATCH v5 net-next 6/7] ip6tlvs: Add netlink interface Tom Herbert
2019-10-07 12:39 ` Simon Horman
2019-12-14 19:25 ` Tom Herbert
2019-10-03 21:58 ` [PATCH v5 net-next 7/7] ip6tlvs: Validation of TX Destination and Hop-by-Hop options Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006132547.stdd4hhj3y4dckqf@netronome.com \
--to=simon.horman@netronome.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).