From: "René van Dorst" <opensource@vdorst.com>
To: MarkLee <Mark-MC.Lee@mediatek.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Sean Wang <sean.wang@mediatek.com>,
John Crispin <john@phrozen.org>,
Nelson Chang <nelson.chang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net,v2 2/2] arm: dts: mediatek: Fix mt7629 dts to reflect the latest dt-binding
Date: Mon, 07 Oct 2019 18:30:28 +0000 [thread overview]
Message-ID: <20191007183028.Horde.dCYJA3Xp9mBh_Bs9Ixa7Sh0@www.vdorst.com> (raw)
In-Reply-To: <20191007070844.14212-3-Mark-MC.Lee@mediatek.com>
Quoting MarkLee <Mark-MC.Lee@mediatek.com>:
> * Removes mediatek,physpeed property from dtsi that is useless in PHYLINK
> * Use the fixed-link property speed = <2500> to set the phy in 2.5Gbit.
> * Set gmac1 to gmii mode that connect to a internal gphy
>
> Signed-off-by: MarkLee <Mark-MC.Lee@mediatek.com>
> --
> v1->v2:
> * SGMII port only support BASE-X at 2.5Gbit.
> ---
> arch/arm/boot/dts/mt7629-rfb.dts | 13 ++++++++++++-
> arch/arm/boot/dts/mt7629.dtsi | 2 --
> 2 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mt7629-rfb.dts
> b/arch/arm/boot/dts/mt7629-rfb.dts
> index 3621b7d2b22a..9980c10c6e29 100644
> --- a/arch/arm/boot/dts/mt7629-rfb.dts
> +++ b/arch/arm/boot/dts/mt7629-rfb.dts
> @@ -66,9 +66,21 @@
> pinctrl-1 = <&ephy_leds_pins>;
> status = "okay";
>
> + gmac0: mac@0 {
> + compatible = "mediatek,eth-mac";
> + reg = <0>;
> + phy-mode = "2500base-x";
> + fixed-link {
> + speed = <2500>;
> + full-duplex;
> + pause;
> + };
> + };
> +
> gmac1: mac@1 {
> compatible = "mediatek,eth-mac";
> reg = <1>;
> + phy-mode = "gmii";
> phy-handle = <&phy0>;
> };
>
> @@ -78,7 +90,6 @@
>
> phy0: ethernet-phy@0 {
> reg = <0>;
> - phy-mode = "gmii";
> };
> };
> };
> diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
> index 9608bc2ccb3f..867b88103b9d 100644
> --- a/arch/arm/boot/dts/mt7629.dtsi
> +++ b/arch/arm/boot/dts/mt7629.dtsi
> @@ -468,14 +468,12 @@
> compatible = "mediatek,mt7629-sgmiisys", "syscon";
> reg = <0x1b128000 0x3000>;
> #clock-cells = <1>;
> - mediatek,physpeed = "2500";
> };
>
> sgmiisys1: syscon@1b130000 {
> compatible = "mediatek,mt7629-sgmiisys", "syscon";
> reg = <0x1b130000 0x3000>;
> #clock-cells = <1>;
> - mediatek,physpeed = "2500";
> };
> };
> };
> --
> 2.17.1
Reviewed-by: René van Dorst <opensource@vdorst.com>
next prev parent reply other threads:[~2019-10-07 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 7:08 [PATCH net,v2 0/2] Update MT7629 to support PHYLINK API MarkLee
2019-10-07 7:08 ` [PATCH net,v2 1/2] net: ethernet: mediatek: Fix MT7629 missing GMII mode support MarkLee
2019-10-07 18:29 ` René van Dorst
2019-10-08 23:06 ` Jakub Kicinski
2019-10-07 7:08 ` [PATCH net,v2 2/2] arm: dts: mediatek: Fix mt7629 dts to reflect the latest dt-binding MarkLee
2019-10-07 18:30 ` René van Dorst [this message]
2019-10-08 23:02 ` [PATCH net,v2 0/2] Update MT7629 to support PHYLINK API Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007183028.Horde.dCYJA3Xp9mBh_Bs9Ixa7Sh0@www.vdorst.com \
--to=opensource@vdorst.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nelson.chang@mediatek.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).