From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
kernel@pengutronix.de, linux-can@vger.kernel.org,
Oliver Hartkopp <socketcan@hartkopp.net>,
Bastian Stender <bst@pengutronix.de>,
Elenita Hinds <ecathinds@gmail.com>,
Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>,
Maxime Jayat <maxime.jayat@mobile-devices.fr>,
Robin van der Gracht <robin@protonic.nl>,
Oleksij Rempel <ore@pengutronix.de>,
David Jander <david@protonic.nl>
Subject: Re: pull-request: can-next 2019-10-07
Date: Tue, 8 Oct 2019 12:09:53 -0700 [thread overview]
Message-ID: <20191008120953.515a3dbd@cakuba.netronome.com> (raw)
In-Reply-To: <2ffa00e7-d447-9216-587d-30396a47ca64@pengutronix.de>
On Mon, 7 Oct 2019 16:38:14 +0200, Marc Kleine-Budde wrote:
> Hello David,
>
> this is a pull request for net-next/master consisting of 12 patches.
>
> The first patch is by Andy Shevchenko for the mcp251x driver and removes
> the legacy platform data from all in-tree users and the driver.
>
> The next two patches target the peak_canfd driver, the first one is by
> me and fixes several checkpatch warnings, the second one is by Stephane
> Grosjean and adds hardware timestamps to the rx skbs.
>
> Followed by two patches for the xilinx_can driver. Again the first is by
> me and fixes checkpatch warnings, the second one is by Anssi Hannula and
> avoids non-requested bus error frames, which improves performance.
>
> Pankaj Sharma's patch for the m_can driver adds support for the one shot
> mode.
>
> YueHaibing provides a patch for the grcan driver to use
> devm_platform_ioremap_resource() to simplify code.
>
> Joakim Zhang provides a similar patch for the flexcan driver.
>
> The last 4 patches are by me and target the rx-offload infrastructure.
> The first 3 fix checkpatch warnings, the last one removes a no-op
> function.
Hi Marc,
I think the correction should have been s/Substract/Subtract/,
sorry for the nit pick.
Would you be able to fix that up or do you prefer to do a follow up?
commit 8e7f9a874626a1aec191b34c2b983f76275d0448
Author: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Mon Oct 7 10:00:25 2019 +0200
can: rx-offload: can_rx_offload_compare(): fix typo
This patch fixes a typo found by checkpatch.
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
diff --git a/drivers/net/can/rx-offload.c b/drivers/net/can/rx-offload.c
index 0daa8c7fe83b..8db07587ce3c 100644
--- a/drivers/net/can/rx-offload.c
+++ b/drivers/net/can/rx-offload.c
@@ -109,7 +109,7 @@ static int can_rx_offload_compare(struct sk_buff *a, struct sk_buff *b)
cb_a = can_rx_offload_get_cb(a);
cb_b = can_rx_offload_get_cb(b);
- /* Substract two u32 and return result as int, to keep
+ /* Substact two u32 and return result as int, to keep
* difference steady around the u32 overflow.
*/
return cb_b->timestamp - cb_a->timestamp;
next prev parent reply other threads:[~2019-10-08 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 14:38 pull-request: can-next 2019-10-07 Marc Kleine-Budde
2019-10-08 19:09 ` Jakub Kicinski [this message]
2019-10-09 7:40 ` Marc Kleine-Budde
2019-10-09 7:33 ` Marc Kleine-Budde
2019-11-12 15:57 Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008120953.515a3dbd@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=bst@pengutronix.de \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=dev.kurt@vandijck-laurijssen.be \
--cc=ecathinds@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=maxime.jayat@mobile-devices.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=ore@pengutronix.de \
--cc=robin@protonic.nl \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).