From: Jiri Pirko <jiri@resnulli.us>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
jakub.kicinski@netronome.com, roopa@cumulusnetworks.com,
dcbw@redhat.com, nikolay@cumulusnetworks.com, mkubecek@suse.cz,
andrew@lunn.ch, parav@mellanox.com, saeedm@mellanox.com,
f.fainelli@gmail.com, stephen@networkplumber.org,
sd@queasysnail.net, sbrivio@redhat.com, pabeni@redhat.com,
mlxsw@mellanox.com
Subject: Re: [patch iproute2-next v2 1/2] ip: add support for alternative name addition/deletion/list
Date: Wed, 9 Oct 2019 13:13:39 +0200 [thread overview]
Message-ID: <20191009111339.GH2326@nanopsycho> (raw)
In-Reply-To: <48c341d6-d611-3f4e-a64d-85719af7ed45@gmail.com>
Mon, Oct 07, 2019 at 11:37:21PM CEST, dsahern@gmail.com wrote:
>On 10/2/19 4:56 AM, Jiri Pirko wrote:
>> diff --git a/ip/iplink.c b/ip/iplink.c
>> index 212a088535da..e3f8a28fe94c 100644
>> --- a/ip/iplink.c
>> +++ b/ip/iplink.c
>> @@ -111,7 +111,9 @@ void iplink_usage(void)
>> "\n"
>> " ip link xstats type TYPE [ ARGS ]\n"
>> "\n"
>> - " ip link afstats [ dev DEVICE ]\n");
>> + " ip link afstats [ dev DEVICE ]\n"
>> + " ip link prop add dev DEVICE [ altname NAME .. ]\n"
>> + " ip link prop del dev DEVICE [ altname NAME .. ]\n");
>
>spell out 'property' here. The matches below on "prop" is fine, but the
>help can show the full name.
Okay.
>
>
>> +
>> + if (matches(*argv, "add") == 0) {
>> + req.n.nlmsg_flags |= NLM_F_EXCL | NLM_F_CREATE | NLM_F_APPEND;
>> + req.n.nlmsg_type = RTM_NEWLINKPROP;
>> + } else if (matches(*argv, "del") == 0) {
>> + req.n.nlmsg_flags |= RTM_DELLINK;
>
>RTM_DELLINK is a command not a netlink flag.
Will fix.
next prev parent reply other threads:[~2019-10-09 11:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 10:56 [patch iproute2-next v2 0/2] ip: add support for alternative names Jiri Pirko
2019-10-02 10:56 ` [patch iproute2-next v2 1/2] ip: add support for alternative name addition/deletion/list Jiri Pirko
2019-10-07 21:37 ` David Ahern
2019-10-09 11:13 ` Jiri Pirko [this message]
2019-10-02 10:56 ` [patch iproute2-next v2 2/2] ip: allow to use alternative names as handle Jiri Pirko
2019-10-07 21:52 ` David Ahern
2019-10-09 12:41 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009111339.GH2326@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=dsahern@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=mkubecek@suse.cz \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pabeni@redhat.com \
--cc=parav@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=saeedm@mellanox.com \
--cc=sbrivio@redhat.com \
--cc=sd@queasysnail.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).