* [PATCH] net/ethernet: xgmac don't set .driver twice
@ 2019-10-09 13:26 Ben Dooks
2019-10-10 4:10 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2019-10-09 13:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Ben Dooks, David S. Miller, netdev, linux-kernel
Cleanup the .driver setup to just do it once, to avoid
the following sparse warning:
drivers/net/ethernet/calxeda/xgmac.c:1914:10: warning: Initializer entry defined twice
drivers/net/ethernet/calxeda/xgmac.c:1920:10: also defined here
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/net/ethernet/calxeda/xgmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index f96a42af1014..af04a2c81adb 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -1914,10 +1914,10 @@ static struct platform_driver xgmac_driver = {
.driver = {
.name = "calxedaxgmac",
.of_match_table = xgmac_of_match,
+ .pm = &xgmac_pm_ops,
},
.probe = xgmac_probe,
.remove = xgmac_remove,
- .driver.pm = &xgmac_pm_ops,
};
module_platform_driver(xgmac_driver);
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/ethernet: xgmac don't set .driver twice
2019-10-09 13:26 [PATCH] net/ethernet: xgmac don't set .driver twice Ben Dooks
@ 2019-10-10 4:10 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2019-10-10 4:10 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, David S. Miller, netdev, linux-kernel
On Wed, 9 Oct 2019 14:26:27 +0100, Ben Dooks wrote:
> Cleanup the .driver setup to just do it once, to avoid
> the following sparse warning:
>
> drivers/net/ethernet/calxeda/xgmac.c:1914:10: warning: Initializer entry defined twice
> drivers/net/ethernet/calxeda/xgmac.c:1920:10: also defined here
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-10 4:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 13:26 [PATCH] net/ethernet: xgmac don't set .driver twice Ben Dooks
2019-10-10 4:10 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).