From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net] tcp: annotate lockless access to tcp_memory_pressure
Date: Wed, 9 Oct 2019 21:50:10 -0700 [thread overview]
Message-ID: <20191009215010.26167c5b@cakuba.netronome.com> (raw)
In-Reply-To: <20191009221015.36077-1-edumazet@google.com>
On Wed, 9 Oct 2019 15:10:15 -0700, Eric Dumazet wrote:
> tcp_memory_pressure is read without holding any lock,
> and its value could be changed on other cpus.
>
> Use READ_ONCE() to annotate these lockless reads.
>
> The write side is already using atomic ops.
>
> Fixes: b8da51ebb1aa ("tcp: introduce tcp_under_memory_pressure()")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks!
prev parent reply other threads:[~2019-10-10 4:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 22:10 [PATCH net] tcp: annotate lockless access to tcp_memory_pressure Eric Dumazet
2019-10-10 4:50 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009215010.26167c5b@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).