From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Alexander Lobakin <alobakin@dlink.ru>
Cc: "David S. Miller" <davem@davemloft.net>,
Edward Cree <ecree@solarflare.com>,
Jiri Pirko <jiri@mellanox.com>,
Eric Dumazet <edumazet@google.com>,
Ido Schimmel <idosch@mellanox.com>,
Paolo Abeni <pabeni@redhat.com>,
Petr Machata <petrm@mellanox.com>,
Sabrina Dubroca <sd@queasysnail.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()
Date: Fri, 11 Oct 2019 15:32:53 +0300 [thread overview]
Message-ID: <20191011123253.GA8693@apalos.home> (raw)
In-Reply-To: <88b9c6742b1169d520376366b683df6c@dlink.ru>
Hi Alexander,
On Fri, Oct 11, 2019 at 03:27:50PM +0300, Alexander Lobakin wrote:
> Hi Ilias,
>
> Ilias Apalodimas wrote 11.10.2019 15:23:
> > Hi Alexander,
> >
> > On Thu, Oct 10, 2019 at 05:42:24PM +0300, Alexander Lobakin wrote:
> > > Hi Dave,
> > >
> > > This series was written as a continuation to commit 323ebb61e32b
> > > ("net: use listified RX for handling GRO_NORMAL skbs"), and also takes
> > > an advantage of listified Rx for GRO. This time, however, we're
> > > targeting at a way more common and used function, napi_gro_receive().
> > >
> > > There are about ~100 call sites of this function, including gro_cells
> > > and mac80211, so even wireless systems will benefit from it.
> > > The only driver that cares about the return value is
> > > ethernet/socionext/netsec, and only for updating statistics. I don't
> > > believe that this change can break its functionality, but anyway,
> > > we have plenty of time till next merge window to pay this change
> > > a proper attention.
> >
> > I don't think this will break anything on the netsec driver. Dropped
> > packets
> > will still be properly accounted for
> >
>
> Thank you for clarification. Do I need to mention you under separate
> Acked-by in v2?
>
Well i only checked for the netsec part. I'll try having a look on the whole
patch and send a proper Acked-by if i get some free time!
> > >
> > > Besides having this functionality implemented for napi_gro_frags()
> > > users, the main reason is the solid performance boost that has been
> > > shown during tests on 1-core MIPS board (with not yet mainlined
> > > driver):
> > >
> > > * no batching (5.4-rc2): ~450/450 Mbit/s
> > > * with gro_normal_batch == 8: ~480/480 Mbit/s
> > > * with gro_normal_batch == 16: ~500/500 Mbit/s
> > >
> > > Applies on top of net-next.
> > > Thanks.
> > >
> > > Alexander Lobakin (2):
> > > net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()
> > > net: core: increase the default size of GRO_NORMAL skb lists to
> > > flush
> > >
> > > net/core/dev.c | 51
> > > +++++++++++++++++++++++++-------------------------
> > > 1 file changed, 26 insertions(+), 25 deletions(-)
> > >
> > > --
> > > 2.23.0
> > >
> >
> > Thanks
> > /Ilias
>
> Regards,
> ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
Regards
/Ilias
prev parent reply other threads:[~2019-10-11 12:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 14:42 [PATCH net-next 0/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() Alexander Lobakin
2019-10-10 14:42 ` [PATCH net-next1/2] " Alexander Lobakin
2019-10-10 18:23 ` Edward Cree
2019-10-11 7:26 ` Alexander Lobakin
2019-10-11 9:20 ` Edward Cree
2019-10-11 9:24 ` Alexander Lobakin
2019-10-10 14:42 ` [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush Alexander Lobakin
2019-10-10 18:16 ` Edward Cree
2019-10-11 7:23 ` Alexander Lobakin
2019-10-12 9:22 ` Alexander Lobakin
2019-10-12 11:18 ` Eric Dumazet
2019-10-12 11:51 ` Alexander Lobakin
2019-10-11 12:23 ` [PATCH net-next 0/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() Ilias Apalodimas
2019-10-11 12:27 ` Alexander Lobakin
2019-10-11 12:32 ` Ilias Apalodimas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011123253.GA8693@apalos.home \
--to=ilias.apalodimas@linaro.org \
--cc=alobakin@dlink.ru \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jaswinder.singh@linaro.org \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@mellanox.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).