From: Martin Lau <kafai@fb.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next 3/3] bpftool: print the comm of the process that loaded the program
Date: Fri, 11 Oct 2019 20:19:13 +0000 [thread overview]
Message-ID: <20191011201910.ynztujumh7dlluez@kafai-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20191011162124.52982-3-sdf@google.com>
On Fri, Oct 11, 2019 at 09:21:24AM -0700, Stanislav Fomichev wrote:
> Print recently added created_by_comm along the existing created_by_uid.
>
> Example with loop1.o (loaded via bpftool):
> 4: raw_tracepoint name nested_loops tag b9472b3ff5753ef2 gpl
> loaded_at 2019-10-10T13:38:18-0700 uid 0 comm bpftool
> xlated 264B jited 152B memlock 4096B
> btf_id 3
Hopefully CAP_BPF may avoid uid 0 in the future.
What will be in "comm" for the python bcc script?
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
> ---
> tools/bpf/bpftool/prog.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
> index 27da96a797ab..400771a942d7 100644
> --- a/tools/bpf/bpftool/prog.c
> +++ b/tools/bpf/bpftool/prog.c
> @@ -296,7 +296,9 @@ static void print_prog_plain(struct bpf_prog_info *info, int fd)
> print_boot_time(info->load_time, buf, sizeof(buf));
>
> /* Piggy back on load_time, since 0 uid is a valid one */
> - printf("\tloaded_at %s uid %u\n", buf, info->created_by_uid);
> + printf("\tloaded_at %s uid %u comm %s\n", buf,
> + info->created_by_uid,
> + info->created_by_comm);
> }
>
> printf("\txlated %uB", info->xlated_prog_len);
> --
> 2.23.0.700.g56cf767bdb-goog
>
next prev parent reply other threads:[~2019-10-11 20:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 16:21 [PATCH bpf-next 1/3] bpf: preserve command of the process that loaded the program Stanislav Fomichev
2019-10-11 16:21 ` [PATCH bpf-next 2/3] tools/bpf: sync bpf.h Stanislav Fomichev
2019-10-11 16:21 ` [PATCH bpf-next 3/3] bpftool: print the comm of the process that loaded the program Stanislav Fomichev
2019-10-11 20:19 ` Martin Lau [this message]
2019-10-11 20:37 ` Stanislav Fomichev
2019-10-11 21:11 ` Arnaldo Carvalho de Melo
2019-10-11 21:30 ` Stanislav Fomichev
2019-10-12 0:10 ` [PATCH bpf-next 1/3] bpf: preserve command " Alexei Starovoitov
2019-10-12 0:38 ` Stanislav Fomichev
2019-10-15 21:21 ` debug annotations for bpf progs. Was: " Alexei Starovoitov
2019-10-15 22:14 ` Andrii Nakryiko
2019-10-15 22:24 ` Alexei Starovoitov
2019-10-15 22:33 ` Andrii Nakryiko
2019-10-15 22:48 ` Alexei Starovoitov
2019-10-15 22:26 ` Stanislav Fomichev
2019-10-16 14:01 ` Daniel Borkmann
2019-10-17 16:28 ` Stanislav Fomichev
2019-10-18 6:19 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011201910.ynztujumh7dlluez@kafai-mbp.dhcp.thefacebook.com \
--to=kafai@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).