From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73358C4360C for ; Sat, 12 Oct 2019 18:38:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 483D520673 for ; Sat, 12 Oct 2019 18:38:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YbFafwXa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729554AbfJLSim (ORCPT ); Sat, 12 Oct 2019 14:38:42 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41513 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728636AbfJLSim (ORCPT ); Sat, 12 Oct 2019 14:38:42 -0400 Received: by mail-pg1-f195.google.com with SMTP id t3so7662688pga.8 for ; Sat, 12 Oct 2019 11:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PYJCvQia0pn4Uc7MYvqlTl+JKad8tbHNffACvYNGz9k=; b=YbFafwXaQ3e0aSJl0kgMctLeYZPOsrSQjxl56JS30OWHSP1NSxgbiGOrDMiFOwYNuZ b1O51nEZwhxzI/m5b/0a4cm8VvNn/XH/v1qM8d2KlXlULmlHli+GXdvIbAXbuwEPOeRP LZFuHSujK0UAQUOqRW+CdnMgKoBCoOzxc5uZddQDne1PO73QI6j9kqwPufrR0WHn8BMW evBmHUrJzf07RNFa9b1VH+L9pth8y3B7TjlGhpXG+7UAmBj3+AAHG8wqPbvzOaMuf6Gv qyZDsr7XE3Jr6m/5a1ym0qytgJlh6U6zWBW3werw5y63Jeff9N1ky+WHocxSkA/XMNp5 uyrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PYJCvQia0pn4Uc7MYvqlTl+JKad8tbHNffACvYNGz9k=; b=OXTHVQvugh/IHyTjndR9ngUEruSeQfY/zwbODIyJpbN3ulZrc9nNBJAfVTux/NvGJt osEJHwsZvqfXD2p/pC8ks85Rpfp+cQWo6yF1GyTlJ5hUif8Q5BR/nNCwz1vgRMTNEFWY 4P361nWTvW4IpvODWmGBEqVTSAH0YE0asJ1YWvFHIeyKHkl0iYAQOp3fb498Rc5kygEq tcydRtGhYhqy+eCpn0Sp0C1MpVJflc1znvz9kKLI1nQeaOa7i3S82bQgIF3p/s3ewnPu zglXMDodIUOFFqPhfNeczpKB+w7Dh9TvupoxoL8/mIL/5rqd5C48xzLs4cywyUWebL5Z 61xA== X-Gm-Message-State: APjAAAUQ/woF2FIQBAPdXe5OOr6gpWA/MAnrvsSPmTROBzHSBa0dHpFE /a769dtQv9G24m7hBcD12fo= X-Google-Smtp-Source: APXvYqxNZ5AE78NYtuWPWCUTwQXLUEEZRD3IU/B1BrgDlp+FNfncY4JUODYEU2TuVO9Id2nKGvrIDQ== X-Received: by 2002:a63:10d:: with SMTP id 13mr24138034pgb.173.1570905521475; Sat, 12 Oct 2019 11:38:41 -0700 (PDT) Received: from localhost (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id z29sm13559880pff.23.2019.10.12.11.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2019 11:38:40 -0700 (PDT) Date: Sat, 12 Oct 2019 11:38:38 -0700 From: Richard Cochran To: Jacob Keller Cc: netdev@vger.kernel.org, Intel Wired LAN , Jeffrey Kirsher , Sergei Shtylyov Subject: Re: [net-next v3 7/7] renesas: reject unsupported external timestamp flags Message-ID: <20191012183838.GH3165@localhost> References: <20190926181109.4871-1-jacob.e.keller@intel.com> <20190926181109.4871-8-jacob.e.keller@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190926181109.4871-8-jacob.e.keller@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Sep 26, 2019 at 11:11:09AM -0700, Jacob Keller wrote: > Fix the renesas PTP support to explicitly reject any future flags that > get added to the external timestamp request ioctl. > > In order to maintain currently functioning code, this patch accepts all > three current flags. This is because the PTP_RISING_EDGE and > PTP_FALLING_EDGE flags have unclear semantics and each driver seems to > have interpreted them slightly differently. This driver doesn't check the flags. Not knowing this HW, I can't say which edges are time stamped. > Cc: Sergei Shtylyov > Signed-off-by: Jacob Keller Reviewed-by: Richard Cochran