From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A33ECE587 for ; Sat, 12 Oct 2019 21:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A21FA2089C for ; Sat, 12 Oct 2019 21:26:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bOOQ6fpa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729764AbfJLV0u (ORCPT ); Sat, 12 Oct 2019 17:26:50 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:38665 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729671AbfJLV0u (ORCPT ); Sat, 12 Oct 2019 17:26:50 -0400 Received: by mail-lj1-f193.google.com with SMTP id b20so13048062ljj.5 for ; Sat, 12 Oct 2019 14:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l+nirvmkHLEBqBl6bw7lxrZbBMmPpPDkXnfegt2ERs0=; b=bOOQ6fpaQHN/FWWatME7AFTtNCrf5dgO1ZU8WA/fBDgO7AEY8yXMZklcpRl4XNkq5T eecBMUbKu/rM+OyMkdQIzmQ2S5VYs8FlfeeBmgWWu0eDBy43EWsj8uX0iYJKIb8MOC5z msROfXVDW89+AcnvuStR3HUCuGucUvwGwo6zA3n9Q6fROANyForjuXNIn/t/f/GpG/o+ mOYoJ9C/2Zm01ycIU62BeDDkv5FRvUkOPXYtrApoCWqeg6wcwF3N+TK1QRjHkegswSBv VvvKqBTKJJ5n2JLYN+WoeHgk7qOBooUw05QbaV05lYRP/+8ZCRDs9y+4Bw7uJGCGl7Z/ yGmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=l+nirvmkHLEBqBl6bw7lxrZbBMmPpPDkXnfegt2ERs0=; b=pnD5bTv/cULsWa88JloG2IOYkMZLsDOSEnL01rq6my4hhyvWz1SScI4RD0qeezZCJo zcdDm90s+htEik8gR/Wx9EtBzpl0OHkA3PGCFBAQZ2wtRAI8yYFipzUsXNNS0XHVY35Y 0/h5LaBPkm8woA+1LCNQheMdeI6EqAuTzq/s4lgXW2g7IN4cakq/lbYjIw+K94SUKNfj N+sOruxufE6lwyfg2Y5l0dCtXDFhwBGw1T0D1HxlP1Njv8k/Dh2O1dXsv5qKIpyTHGmZ OFYsIYisPYZxLuwG7Pg0fHLi0OLxVQ1RudyAxO5QQs1Q6Ec9v07i89cXGQQqnDEpPNge Bqwg== X-Gm-Message-State: APjAAAVM7Knztk4Uqu47BB3fiIK+unOXqywPSemMpuw2rJPY17XCk31T drdCIDXwXb4ErOUudbvaQ7MMkQ== X-Google-Smtp-Source: APXvYqx/zpvokyTYRRQY1lgFNCEeQnhx9hVn6IE+ZWV4Trp0oLV6Oz0w6zjygCjzS9E+uhEs2zkbfA== X-Received: by 2002:a2e:8315:: with SMTP id a21mr13301291ljh.73.1570915608214; Sat, 12 Oct 2019 14:26:48 -0700 (PDT) Received: from khorivan (88-201-94-178.pool.ukrtel.net. [178.94.201.88]) by smtp.gmail.com with ESMTPSA id x30sm2931384ljd.39.2019.10.12.14.26.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 12 Oct 2019 14:26:47 -0700 (PDT) Date: Sun, 13 Oct 2019 00:26:45 +0300 From: Ivan Khoronzhuk To: Sergei Shtylyov Cc: ast@kernel.org, daniel@iogearbox.net, yhs@fb.com, davem@davemloft.net, jakub.kicinski@netronome.com, hawk@kernel.org, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, clang-built-linux@googlegroups.com, ilias.apalodimas@linaro.org Subject: Re: [PATCH v5 bpf-next 09/15] samples/bpf: use own flags but not HOSTCFLAGS Message-ID: <20191012212643.GC3689@khorivan> Mail-Followup-To: Sergei Shtylyov , ast@kernel.org, daniel@iogearbox.net, yhs@fb.com, davem@davemloft.net, jakub.kicinski@netronome.com, hawk@kernel.org, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, clang-built-linux@googlegroups.com, ilias.apalodimas@linaro.org References: <20191011002808.28206-1-ivan.khoronzhuk@linaro.org> <20191011002808.28206-10-ivan.khoronzhuk@linaro.org> <99f76e2f-ed76-77e0-a470-36ae07567111@cogentembedded.com> <20191011095715.GB3689@khorivan> <3fb88a06-5253-1e48-9bea-2d31a443250b@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <3fb88a06-5253-1e48-9bea-2d31a443250b@cogentembedded.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 11, 2019 at 02:16:05PM +0300, Sergei Shtylyov wrote: >On 10/11/2019 12:57 PM, Ivan Khoronzhuk wrote: > >>>> While compiling natively, the host's cflags and ldflags are equal to >>>> ones used from HOSTCFLAGS and HOSTLDFLAGS. When cross compiling it >>>> should have own, used for target arch. While verification, for arm, >>> >>> While verifying. >> While verification stage. > > While *in* verification stage, "while" doesn't combine with nouns w/o >a preposition. Sergei, better add me in cc list when msg is to me I can miss it. Regarding the language lesson, thanks, I will keep it in mind next time, but the issue is not rude, if it's an issue at all, so I better leave it as is, as not reasons to correct it w/o code changes and everyone is able to understand it. > >>>> arm64 and x86_64 the following flags were used always: >>>> >>>> -Wall -O2 >>>> -fomit-frame-pointer >>>> -Wmissing-prototypes >>>> -Wstrict-prototypes >>>> >>>> So, add them as they were verified and used before adding >>>> Makefile.target and lets omit "-fomit-frame-pointer" as were proposed >>>> while review, as no sense in such optimization for samples. >>>> >>>> Signed-off-by: Ivan Khoronzhuk >>> [...] > >MBR, Sergei -- Regards, Ivan Khoronzhuk