From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CC4ECE587 for ; Mon, 14 Oct 2019 15:04:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69DBE21A4A for ; Mon, 14 Oct 2019 15:04:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733191AbfJNPEo (ORCPT ); Mon, 14 Oct 2019 11:04:44 -0400 Received: from mga14.intel.com ([192.55.52.115]:58874 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732854AbfJNPEn (ORCPT ); Mon, 14 Oct 2019 11:04:43 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Oct 2019 08:04:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,296,1566889200"; d="scan'208";a="195016178" Received: from lkp-server01.sh.intel.com (HELO lkp-server01) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 14 Oct 2019 08:04:41 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1iK1to-00035y-Oc; Mon, 14 Oct 2019 23:04:40 +0800 Date: Mon, 14 Oct 2019 23:04:28 +0800 From: kbuild test robot To: Pankaj Sharma Cc: kbuild-all@lists.01.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net, eugen.hristev@microchip.com, ludovic.desroches@microchip.com, pankaj.dubey@samsung.com, rcsekar@samsung.com, Pankaj Sharma , Sriram Dash Subject: [PATCH] can: m_can: fix boolreturn.cocci warnings Message-ID: <20191014150428.xhhc43ovkxm6oxf2@332d0cec05f4> References: <1571052844-22633-1-git-send-email-pankj.sharma@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1571052844-22633-1-git-send-email-pankj.sharma@samsung.com> X-Patchwork-Hint: ignore User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: kbuild test robot drivers/net/can/m_can/m_can.c:783:9-10: WARNING: return of 0/1 in function 'is_protocol_err' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 46946163ac61 ("can: m_can: add support for handling arbitration error") CC: Pankaj Sharma Signed-off-by: kbuild test robot --- url: https://github.com/0day-ci/linux/commits/Pankaj-Sharma/can-m_can-add-support-for-handling-arbitration-error/20191014-193532 m_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -780,9 +780,9 @@ static inline bool is_lec_err(u32 psr) static inline bool is_protocol_err(u32 irqstatus) { if (irqstatus & IR_ERR_LEC_31X) - return 1; + return true; else - return 0; + return false; } static int m_can_handle_protocol_error(struct net_device *dev, u32 irqstatus)