From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH v2 1/3] net: phylink: switch to using fwnode_gpiod_get_index()
Date: Mon, 14 Oct 2019 18:55:27 +0100 [thread overview]
Message-ID: <20191014175527.GQ25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20191014174022.94605-2-dmitry.torokhov@gmail.com>
On Mon, Oct 14, 2019 at 10:40:20AM -0700, Dmitry Torokhov wrote:
> Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use
> the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but
> works with arbitrary firmware node.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> drivers/net/phy/phylink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index a5a57ca94c1a..c34ca644d47e 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -168,8 +168,8 @@ static int phylink_parse_fixedlink(struct phylink *pl,
> pl->link_config.pause |= MLO_PAUSE_ASYM;
>
> if (ret == 0) {
> - desc = fwnode_get_named_gpiod(fixed_node, "link-gpios",
> - 0, GPIOD_IN, "?");
> + desc = fwnode_gpiod_get_index(fixed_node, "link", 0,
> + GPIOD_IN, "?");
>
> if (!IS_ERR(desc))
> pl->link_gpio = desc;
> --
> 2.23.0.700.g56cf767bdb-goog
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-10-14 17:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 17:40 [PATCH v2 0/3] net: phy: switch to using fwnode_gpiod_get_index Dmitry Torokhov
2019-10-14 17:40 ` [PATCH v2 1/3] net: phylink: switch to using fwnode_gpiod_get_index() Dmitry Torokhov
2019-10-14 17:55 ` Russell King - ARM Linux admin [this message]
2019-10-14 20:30 ` kbuild test robot
2019-10-15 13:02 ` kbuild test robot
2019-10-14 17:40 ` [PATCH v2 2/3] net: phy: fixed_phy: fix use-after-free when checking link GPIO Dmitry Torokhov
2019-10-15 12:54 ` Andrew Lunn
2019-10-14 17:40 ` [PATCH v2 3/3] net: phy: fixed_phy: switch to using fwnode_gpiod_get_index Dmitry Torokhov
2019-10-14 22:37 ` kbuild test robot
2019-10-16 3:18 ` [PATCH v2 0/3] net: phy: " David Miller
2019-11-05 0:40 ` Dmitry Torokhov
2019-11-05 0:55 ` Russell King - ARM Linux admin
2019-11-05 17:27 ` Dmitry Torokhov
2019-11-05 18:04 ` David Miller
2019-11-05 18:20 ` Dmitry Torokhov
2019-11-13 21:26 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014175527.GQ25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).