From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3EF2C10F14 for ; Tue, 15 Oct 2019 17:55:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D6E782067B for ; Tue, 15 Oct 2019 17:55:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388905AbfJORzx (ORCPT ); Tue, 15 Oct 2019 13:55:53 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37662 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731694AbfJORzw (ORCPT ); Tue, 15 Oct 2019 13:55:52 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C82EC1504B49C; Tue, 15 Oct 2019 10:55:51 -0700 (PDT) Date: Tue, 15 Oct 2019 10:55:51 -0700 (PDT) Message-Id: <20191015.105551.1592575105039759451.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, phil@raspberrypi.org, jonathan@raspberrypi.org, matthias.bgg@kernel.org, linux-rpi-kernel@lists.infradead.org, wahrenst@gmx.net, nsaenzjulienne@suse.de, opendmb@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: bcmgenet: Set phydev->dev_flags only for internal PHYs From: David Miller In-Reply-To: <20191011195349.9661-1-f.fainelli@gmail.com> References: <20191011195349.9661-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 15 Oct 2019 10:55:52 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Florian Fainelli Date: Fri, 11 Oct 2019 12:53:49 -0700 > phydev->dev_flags is entirely dependent on the PHY device driver which > is going to be used, setting the internal GENET PHY revision in those > bits only makes sense when drivers/net/phy/bcm7xxx.c is the PHY driver > being used. > > Fixes: 487320c54143 ("net: bcmgenet: communicate integrated PHY revision to PHY driver") > Signed-off-by: Florian Fainelli Applied and queued up for -stable, thanks Florian.