From: David Miller <davem@davemloft.net>
To: alexandre.belloni@bootlin.com
Cc: vz@mleia.com, slemieux.tyco@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] net: lpc_eth: parse phy nodes from device tree
Date: Tue, 15 Oct 2019 17:22:27 -0700 (PDT) [thread overview]
Message-ID: <20191015.172227.1754483638007790724.davem@davemloft.net> (raw)
In-Reply-To: <20191010204530.15150-2-alexandre.belloni@bootlin.com>
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: Thu, 10 Oct 2019 22:45:30 +0200
> When connected to a micrel phy, phy_find_first doesn't work properly
> because the first phy found is on address 0, the broadcast address but, the
> first thing the phy driver is doing is disabling this broadcast address.
> The phy is then available only on address 1 but the mdio driver doesn't
> know about it.
>
> Instead, register the mdio bus using of_mdiobus_register and try to find
> the phy description in device tree before falling back to phy_find_first.
>
> This ultimately also allows to describe the interrupt the phy is connected
> to.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Please respond to Andrew's feedback.
next prev parent reply other threads:[~2019-10-16 0:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 20:45 [PATCH 1/2] dt-bindings: net: lpc-eth: document optional properties Alexandre Belloni
2019-10-10 20:45 ` [PATCH 2/2] net: lpc_eth: parse phy nodes from device tree Alexandre Belloni
2019-10-14 23:45 ` Andrew Lunn
2019-10-16 0:22 ` David Miller [this message]
2019-10-16 18:23 ` David Miller
2019-10-16 19:14 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015.172227.1754483638007790724.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).