From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC3CFA372B for ; Wed, 16 Oct 2019 17:44:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20EF92082C for ; Wed, 16 Oct 2019 17:44:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394067AbfJPRoN (ORCPT ); Wed, 16 Oct 2019 13:44:13 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52198 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389705AbfJPRoN (ORCPT ); Wed, 16 Oct 2019 13:44:13 -0400 Received: from localhost (unknown [IPv6:2603:3023:50c:85e1:5314:1b70:2a53:887e]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5853A142387B6; Wed, 16 Oct 2019 10:44:12 -0700 (PDT) Date: Wed, 16 Oct 2019 13:44:11 -0400 (EDT) Message-Id: <20191016.134411.315258296003464370.davem@davemloft.net> To: ben.dooks@codethink.co.uk Cc: daniel@iogearbox.net, linux-kernel@lists.codethink.co.uk, ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, jakub.kicinski@netronome.com, hawk@kernel.org, john.fastabend@gmail.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: bpf: add static in net/core/filter.c From: David Miller In-Reply-To: References: <20191016131020.GE21367@pc-63.home> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Oct 2019 10:44:13 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ben Dooks Date: Wed, 16 Oct 2019 14:11:52 +0100 > Hmm, your config it does, I get /none/ of these warnings. > > I guess a lot of this is being built whether or not is then used. When you are making changes like this, unless you have done a full grep over the tree and are %100 sure it is unrefrenced you should do at a minimum an allmodconfig build. Otherwise by definition you are not testing the build of this change.