From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF280FA372A for ; Wed, 16 Oct 2019 17:50:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90F8421D80 for ; Wed, 16 Oct 2019 17:50:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390421AbfJPRuG (ORCPT ); Wed, 16 Oct 2019 13:50:06 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52296 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390071AbfJPRuF (ORCPT ); Wed, 16 Oct 2019 13:50:05 -0400 Received: from localhost (unknown [IPv6:2603:3023:50c:85e1:5314:1b70:2a53:887e]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C43EB14239BEE; Wed, 16 Oct 2019 10:50:04 -0700 (PDT) Date: Wed, 16 Oct 2019 13:50:03 -0400 (EDT) Message-Id: <20191016.135003.672960397161023411.davem@davemloft.net> To: jakub.kicinski@netronome.com Cc: tanhuazhong@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, salil.mehta@huawei.com, yisen.zhuang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations From: David Miller In-Reply-To: <20191016101943.415d73cf@cakuba.netronome.com> References: <1571210231-29154-1-git-send-email-tanhuazhong@huawei.com> <20191016101943.415d73cf@cakuba.netronome.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Oct 2019 10:50:05 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski Date: Wed, 16 Oct 2019 10:19:43 -0700 > On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote: >> This patch-set includes some bugfixes and code optimizations >> for the HNS3 ethernet controller driver. > > The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4 > should be a separate series targeting the net tree :( Agreed, there are legitimate bug fixes. I have to say that I see this happening a lot, hns3 bug fixes targetting net-next in a larger series of cleanups and other kinds of changes. Please handle this delegation properly. Send bug fixes as a series targetting 'net', and send everything else targetting 'net-next'.