From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58CA7ECE599 for ; Thu, 17 Oct 2019 01:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21C932067B for ; Thu, 17 Oct 2019 01:33:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="X9w80Ptr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389980AbfJQBdJ (ORCPT ); Wed, 16 Oct 2019 21:33:09 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:37978 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727399AbfJQBdJ (ORCPT ); Wed, 16 Oct 2019 21:33:09 -0400 Received: by mail-lf1-f66.google.com with SMTP id u28so465666lfc.5 for ; Wed, 16 Oct 2019 18:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=tYG8C0JKzORc+5dYOCIn/21BVZWCYMghLXihrMVQ54M=; b=X9w80PtrLlVIaGKEWD6FdEwxLD8kLljv3QsiwLlGVNwFJBbzhkXJSSnLoohL7RMA8H dqYiQAAdjkk2AYwxiYodZUiqaMgXA1rSjSD+86cdJGIAldnqHNMgh48I0PpgQrhae/aV Fypvjplw7Gr5UmxJtSfvmeZXstD7e0gV3pvyvak0lmHSAwKh8LZrr+TYgUUuFanx1mJe VyUJSyCc0qFG5TpHuuvIGxyttZ7u2DuYmfuEBKqPXqyY/EujL3qQL2EYqMFXC5ZQnrfJ 6Z7f7Tdtn1hj9ra8BwpR6B3LNIZcS/4hF/YEVAQkqEtSSHZnhyAneADQupCi99fJi/Y/ RbiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=tYG8C0JKzORc+5dYOCIn/21BVZWCYMghLXihrMVQ54M=; b=j38b2vV2Gu9F4/rr2KX2P0Y7Gg0BzvRY6uU2c4vqyv+Wr1yDEijpw8F/w3YHzv/KIG lxj170rLzmK+NrFEIRJ+tn/cIKCnIs1NVCdxm8Ky5j7kE4+G9o9RzHRv1qchIrw9aWEp aZT4bJLwrqMpUYj75zYLRq233TaIMTGcHBLjMu/5mbzQFpPKXuUk30Myrx/HQToSd1cP RrKjHIRFbfoZcPbmJ66gg4OWbyrop1uNYg6HJkqzY1pWoeu8ROMQxxm27ejfEi49rbaM Sv2jb3+QvI3Etfy7IhrW7cIWKs/P52439O61GHynUPe5xh5i4cK3zIKx4H7uuzZCqWAH dJaA== X-Gm-Message-State: APjAAAXnQSG/2hb4btkP9EUxpdncKEC6azVuV9nAGF7x/tLhtvXVidr0 GnyelKeFAoI7SvgciMBnP7fvUw== X-Google-Smtp-Source: APXvYqzfJ8IyXPEZG4XslMmSrMrgW058lrEdPil0XmDSB/K770kN23nXhejr395qA4EaOcrV/8vwJA== X-Received: by 2002:ac2:4d1b:: with SMTP id r27mr400457lfi.133.1571275987087; Wed, 16 Oct 2019 18:33:07 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id t8sm319046ljd.18.2019.10.16.18.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 18:33:06 -0700 (PDT) Date: Wed, 16 Oct 2019 18:33:00 -0700 From: Jakub Kicinski To: Jonathan Lemon Cc: , , , , , Subject: Re: [PATCH 03/10 net-next] net/mlx5e: RX, Internal DMA mapping in page_pool Message-ID: <20191016183300.63eb3cd1@cakuba.netronome.com> In-Reply-To: <20191016225028.2100206-4-jonathan.lemon@gmail.com> References: <20191016225028.2100206-1-jonathan.lemon@gmail.com> <20191016225028.2100206-4-jonathan.lemon@gmail.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 16 Oct 2019 15:50:21 -0700, Jonathan Lemon wrote: > From: Tariq Toukan > > After RX page-cache is removed in previous patch, let the > page_pool be responsible for the DMA mapping. > > Issue: 1487631 > Signed-off-by: Tariq Toukan > > Signed-off-by: Jonathan Lemon IIUC you'll need to add DMA syncs here, no? map/unmap has syncing as side effect.