From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B164FA372A for ; Thu, 17 Oct 2019 17:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27D842089C for ; Thu, 17 Oct 2019 17:46:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394636AbfJQRqJ (ORCPT ); Thu, 17 Oct 2019 13:46:09 -0400 Received: from correo.us.es ([193.147.175.20]:58098 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440778AbfJQRqI (ORCPT ); Thu, 17 Oct 2019 13:46:08 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 8F21BA1A33A for ; Thu, 17 Oct 2019 19:46:03 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 81846DA8E8 for ; Thu, 17 Oct 2019 19:46:03 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 6D358B7FFE; Thu, 17 Oct 2019 19:46:03 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 81F7A202B7; Thu, 17 Oct 2019 19:46:01 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 17 Oct 2019 19:46:01 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 4E87242EF4E2; Thu, 17 Oct 2019 19:46:01 +0200 (CEST) Date: Thu, 17 Oct 2019 19:46:03 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jakub Kicinski Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, jiri@resnulli.us, saeedm@mellanox.com, vishal@chelsio.com, vladbu@mellanox.com, ecree@solarflare.com Subject: Re: [PATCH net-next,v5 3/4] net: flow_offload: mangle action at byte level Message-ID: <20191017174603.m3riooywbgy2r5hr@salvia> References: <20191014221051.8084-1-pablo@netfilter.org> <20191014221051.8084-4-pablo@netfilter.org> <20191016163651.230b60e1@cakuba.netronome.com> <20191017161157.rr4lrolsjbnmk3ke@salvia> <20191017103059.3b7ff828@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191017103059.3b7ff828@cakuba.netronome.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Oct 17, 2019 at 10:30:59AM -0700, Jakub Kicinski wrote: [...] > Ed requested this was a opt-in/helper the driver can call if they > choose to. Please do that. Please provide selftests. I will follow up to support for mangling two ports with one single u32 word, no problem. Making this opt-in will just leave things as bad as they are right now, with drivers that are very much hard to read.